Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CTID in tx command returns invalidParams on lowercase hex #5049

Merged
merged 7 commits into from
Jul 5, 2024

Merge branch 'develop' into br_fix_ctid_lowercase

7da5cdd
Select commit
Loading
Failed to load commit list.
Merged

fix CTID in tx command returns invalidParams on lowercase hex #5049

Merge branch 'develop' into br_fix_ctid_lowercase
7da5cdd
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 5, 2024 in 1s

71.4% (target 60.0%)

View this Pull Request on Codecov

71.4% (target 60.0%)

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.4%. Comparing base (a17ccca) to head (7da5cdd).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5049   +/-   ##
=======================================
  Coverage     71.4%   71.4%           
=======================================
  Files          796     796           
  Lines        67031   67031           
  Branches     10864   10863    -1     
=======================================
  Hits         47834   47834           
  Misses       19197   19197           
Files Coverage Δ
src/xrpld/rpc/CTID.h 100.0% <100.0%> (ø)

... and 3 files with indirect coverage changes

Impacted file tree graph