fix account_objects to disallow filtering by types that an account ca… #5056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvadari
reviewed
Jun 25, 2024
cindyyan317
reviewed
Jul 2, 2024
scottschurr
reviewed
Jul 4, 2024
There was a problem hiding this comment.
The fix looks good as far as I'm concerned. However,
- I raised a concern about how test failures will be handled, and suggested how I would resolve it. But I'm open to other thoughts.
- I also raised a concern about lambda naming (in general) in the test file.
I pushed commits with my suggested fixes to this branch: https://github.com/scottschurr/rippled/commits/yinyiqian1-br_fix_invalid_type/
- My suggestions for improving test failure messages are in commit ad508ff
- My suggestions for renaming the lambdas are in this commit: b419bd0
You are welcome to look at, cherry-pick, or ignore those commits as you wish. But at the very least I hope for some discussion.
Thanks for the contribution!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5056 +/- ##
=========================================
- Coverage 71.4% 71.3% -0.0%
=========================================
Files 796 796
Lines 67031 67039 +8
Branches 10865 10886 +21
=========================================
- Hits 47830 47810 -20
- Misses 19201 19229 +28
... and 8 files with indirect coverage changes |
scottschurr
approved these changes
Jul 5, 2024
shawnxie999
added
the
Passed
vlntb
pushed a commit
to vlntb/rippled
that referenced
this pull request
Aug 23, 2024
* `account_objects` returns an invalid field error if `type` is not supported. This includes objects an account can't own, or which are unsupported by `account_objects` * Includes: * Amendments * Directory Node * Fee Settings * Ledger Hashes * Negative UNL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4681
High Level Overview of Change
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)