[TRIVIAL] Fix NuDB build error

[ximinez]

High Level Overview of Change

Fix a build error that seems to be limited to non-unity builds on Windows (Visual Studio) due to a missing #include in NuDB.

Context of Change

I think the reordering of #includes in the physical redesign PR (#4997) removed a silent dependency from one of the headers in NuDB. The dependency version of NuDB didn't change, as far as I can tell. CI didn't catch the issue because the Windows build uses unity to save time.

The error is:

C:\Users\passp\.conan\data\nudb\2.0.8\_\_\package\5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9\include\nudb/detail/stream.hpp(64,20): error C2039: 'logic_error': is not a member of 'std' [C:\Dev\rippled\upstream\build\cmake\msvc19.OFF\rippled.vcxproj]

std::logic_error requires <stdexcept>, but nudb/detail/stream.hpp does not include it.

My assumption is some other header that had previously been ordered before stream.hpp and included <stdexcept> is now ordered after stream.hpp. I don't think it's worth figuring out which file it is, because it's obviously a problem with NuDB.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• Build

Future Tasks

See also: cppalliance/NuDB#100

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.4%. Comparing base (d54151e) to head (76561ad).

Additional details and impacted files

@@            Coverage Diff            @@
##           develop   #5061     +/-   ##
=========================================
- Coverage     71.4%   71.4%   -0.0%     
=========================================
  Files          796     796             
  Lines        67039   67039             
  Branches     10865   10867      +2     
=========================================
- Hits         47841   47833      -8     
- Misses       19198   19206      +8     

see 5 files with indirect coverage changes

[ximinez]

Rewrote this to patch the source via Conan.

[thejohnfreeman]

Do you want to add an instruction to BUILD.md explaining how to export the right version of nudb from external/nudb?