Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update gcovr EXCLUDE #5084

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

Bronek
Copy link
Collaborator

@Bronek Bronek commented Jul 31, 2024

High Level Overview of Change

Update EXCLUDE options for gcovr invocation in coverage target to stay close to .codecov.yml options

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

@Bronek Bronek requested a review from thejohnfreeman July 31, 2024 14:05
@Bronek Bronek marked this pull request as ready for review July 31, 2024 14:06
@Bronek Bronek added Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. Trivial labels Jul 31, 2024
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.4%. Comparing base (f5a3495) to head (003396c).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5084   +/-   ##
=======================================
  Coverage     71.4%   71.4%           
=======================================
  Files          796     796           
  Lines        67042   67042           
  Branches     10865   10864    -1     
=======================================
+ Hits         47842   47844    +2     
+ Misses       19200   19198    -2     

see 2 files with indirect coverage changes

Impacted file tree graph

@ximinez ximinez merged commit eedfec0 into XRPLF:develop Aug 2, 2024
17 of 18 checks passed
vlntb pushed a commit to vlntb/rippled that referenced this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. Trivial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants