-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposed version 2.2.2 #5115
Proposed version 2.2.2 #5115
Conversation
* Log when duplicate concurrent inbound ledger are filtered. * RAII for containers that track concurrent inbound ledger. * Comment on when to asynchronously acquire inbound ledgers, which is possible to be always OK, but should have further review. * Other small logging changes Co-authored-by: Ed Hennis <[email protected]>
* refactor filtering of validations to specifically avoid concurrent checkAccept() calls for the same validation ledger hash. * Log when duplicate concurrent validation requests are filtered. * RAII for containers that track concurrent validation requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR should edit The changes can be relatively small. The opening sentence of this PR is good for the overview. |
I saw this after merging the PR. Do you think we'd be ok adding release notes when we reverse merge into |
FYI @ximinez @mtrippled - this seems to make a difference on FH nodes @ xrplcluster - less transitions, less hiccups in ledger steram over websocket. Installed it on half the machines and the ones with 2.2.2 definitely seem to do significantly better. |
This is great news, @WietseWind ! Thanks for the update! |
High Level Overview of Change
This is a hotfix release that fixes a ongoing issue on Mainnet where a majority of UNL validators will stall during consensus processing due to lock contention, preventing ledgers from being validated for up to two minutes.
The base branch is
master
. This PR will be merged with--ff-only
(not squashed or rebased, and not using the GitHub UI) tomaster
, and reverse-merged todevelop
. Do not use the Github UI to merge this PRThis PR / branch is identical to #5106, which is currently being tested, with two exceptions:
Type of Change