feature: Single Asset Vault

[thejohnfreeman]

Starting a draft PR for incremental review.

Based on:

• MPT branch with variant STIssue
• Consolidate definitions of fields, objects, transactions, and features #5122
• Add a new serialized type: STNumber #5121

[donovanhide]

Is there an XLS document for this new feature? Thanks.

[Bronek]

Is there an XLS document for this new feature? Thanks.

Hi Donovan, please note this is a Draft, meaning the implementation here should be in no way considered complete or reflecting the actual product which will be subject to amendment voting. Having said that, this project started with the discussion at XRPLF/XRPL-Standards#190

[codecov]

Codecov Report

Attention: Patch coverage is 77.60417% with 344 lines in your changes missing coverage. Please review.

Project coverage is 76.0%. Comparing base (bf4a7b6) to head (b93e27c).

Files with missing lines	Patch %	Lines
src/xrpld/app/tx/detail/VaultSet.cpp	0.0%	67 Missing ⚠️
src/libxrpl/protocol/STAmount.cpp	74.0%	45 Missing ⚠️
src/xrpld/rpc/handlers/LedgerEntry.cpp	5.9%	32 Missing ⚠️
src/xrpld/app/tx/detail/InvariantCheck.cpp	65.5%	30 Missing ⚠️
src/libxrpl/basics/MPTAmount.cpp	8.3%	22 Missing ⚠️
src/xrpld/app/tx/detail/Payment.cpp	85.4%	21 Missing ⚠️
src/libxrpl/protocol/STIssue.cpp	52.9%	16 Missing ⚠️
src/xrpld/ledger/detail/View.cpp	91.8%	13 Missing ⚠️
src/libxrpl/protocol/Asset.cpp	72.4%	8 Missing ⚠️
src/libxrpl/protocol/STNumber.cpp	73.3%	8 Missing ⚠️
... and 25 more

Additional details and impacted files

@@            Coverage Diff            @@
##           develop   #5147     +/-   ##
=========================================
- Coverage     76.2%   76.0%   -0.2%     
=========================================
  Files          760     780     +20     
  Lines        61568   62619   +1051     
  Branches      8126    8303    +177     
=========================================
+ Hits         46898   47604    +706     
- Misses       14670   15015    +345     

Files with missing lines	Coverage Δ
include/xrpl/basics/MPTAmount.h	100.0% <100.0%> (ø)
include/xrpl/basics/Number.h	100.0% <100.0%> (ø)
include/xrpl/basics/base_uint.h	97.2% <ø> (+0.6%)	⬆️
include/xrpl/protocol/AMMCore.h	100.0% <ø> (ø)
include/xrpl/protocol/AmountConversions.h	87.5% <100.0%> (ø)
include/xrpl/protocol/Feature.h	100.0% <ø> (ø)
include/xrpl/protocol/Indexes.h	100.0% <100.0%> (ø)
include/xrpl/protocol/Issue.h	100.0% <100.0%> (ø)
include/xrpl/protocol/MPTIssue.h	100.0% <100.0%> (ø)
include/xrpl/protocol/SField.h	100.0% <ø> (ø)
... and 93 more

... and 8 files with indirect coverage changes

[thejohnfreeman]

Will open a new PR, easier to review, in my personal fork.