Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed 2.3.0-rc2 #5191

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Proposed 2.3.0-rc2 #5191

merged 3 commits into from
Nov 13, 2024

Conversation

ximinez
Copy link
Collaborator

@ximinez ximinez commented Nov 12, 2024

High Level Overview of Change

This is a release candidate for the 2.3.0 release.

Highlights:

The base branch is release. All releases (including betas) go in release. This PR will be merged with --ff-only (not squashed or rebased, and not using the GitHub UI) to both release and develop.

Context of Change

This release candidate contains bug fixes for issues discovered in 2.3.0-rc1.

Type of Change

  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.9%. Comparing base (9d58f11) to head (838978b).
Report is 3 commits behind head on release.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           release   #5191     +/-   ##
=========================================
- Coverage     77.9%   77.9%   -0.0%     
=========================================
  Files          782     782             
  Lines        66616   66621      +5     
  Branches      8161    8161             
=========================================
  Hits         51902   51902             
- Misses       14714   14719      +5     
Files with missing lines Coverage Δ
src/libxrpl/protocol/BuildInfo.cpp 98.2% <ø> (ø)
src/libxrpl/protocol/SField.cpp 79.1% <ø> (ø)
src/xrpld/rpc/handlers/LedgerEntry.cpp 79.8% <100.0%> (+0.2%) ⬆️

... and 8 files with indirect coverage changes

Impacted file tree graph

@intelliot intelliot requested review from Bronek and mvadari November 13, 2024 18:45
@intelliot
Copy link
Collaborator

notes from huddle: Bronek will check Mac build; other reviews are optional

@ximinez ximinez merged commit 838978b into release Nov 13, 2024
31 of 32 checks passed
@ximinez ximinez deleted the release-next branch November 13, 2024 21:38
@ximinez ximinez restored the release-next branch November 18, 2024 19:01
@ximinez ximinez deleted the release-next branch November 18, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants