Cleanup API-CHANGELOG.md #5207
Open
Cleanup API-CHANGELOG.md #5207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5207 +/- ##
=========================================
- Coverage 77.9% 77.9% -0.0%
=========================================
Files 784 784
Lines 66681 66680 -1
Branches 8162 8157 -5
=========================================
- Hits 51950 51922 -28
- Misses 14731 14758 +27 see 8 files with indirect coverage changes |
mvadari
reviewed
Dec 2, 2024
|
|
||
| ### Breaking change in 2.3 | ||
| ### Breaking changes in 2.3.0 |
There was a problem hiding this comment.
Suggested change
| ### Breaking changes in 2.3.0 | |
| ### Breaking changes |
2.3.0 is already specified in the header, I don't think it needs to be specified here as well
There was a problem hiding this comment.
We double-specified it so that the anchor links are unique and thus linkable. Example: https://github.com/XRPLF/rippled/blob/develop/API-CHANGELOG.md#breaking-changes-in-111
If it's just Breaking changes then the anchor link becomes ambiguous
mvadari
reviewed
Dec 2, 2024
|
|
||
| - `book_changes`: If the requested ledger version is not available on this node, a `ledgerNotFound` error is returned and the node does not attempt to acquire the ledger from the p2p network (as with other non-admin RPCs). | ||
|
|
||
| Admins can still attempt to retrieve old ledgers with the `ledger_request` RPC. | ||
|
|
||
| ### Addition in 2.3 | ||
| ### Additions and bugfixes in 2.3.0 |
There was a problem hiding this comment.
Suggested change
| ### Additions and bugfixes in 2.3.0 | |
| ### Additions and bugfixes |
intelliot
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Some of the PRs merged before the 2.3.0 release have mangled the
API-CHANGELOG.md(e.g. #5096 ) . Lets clean this up.Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)