Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed 2.4.0-b1 #5212

Closed
wants to merge 4 commits into from
Closed

Proposed 2.4.0-b1 #5212

wants to merge 4 commits into from

Conversation

ximinez
Copy link
Collaborator

@ximinez ximinez commented Dec 3, 2024

High Level Overview of Change

This is a beta for the 2.4.0 release.

Highlights:

The base branch is release. All releases (including betas) go in release. This PR will be merged with --ff-only (not squashed or rebased, and not using the GitHub UI) to both release and develop.

Context of Change

This introduces

  • Antithesis instrumentation, and a new model for writing (most) asserts.
  • A few unit test changes and additions.

Type of Change

  • Release

API Impact

No API impact.

Bronek and others added 4 commits December 3, 2024 14:54
* Copy Antithesis SDK version 0.4.0 to directory external/
* Add build option `voidstar` to enable instrumentation with Antithesis SDK
* Define instrumentation macros ASSERT and UNREACHABLE in terms of regular C assert
* Replace asserts with named ASSERT or UNREACHABLE
* Add UNREACHABLE to LogicError
* Document instrumentation macros in CONTRIBUTING.md
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 79.84145% with 178 lines in your changes missing coverage. Please review.

Project coverage is 77.9%. Comparing base (f64cf91) to head (a2f5459).

Files with missing lines Patch % Lines
src/xrpld/overlay/detail/PeerImp.cpp 0.0% 15 Missing ⚠️
src/libxrpl/json/json_value.cpp 40.0% 12 Missing ⚠️
src/xrpld/app/ledger/detail/LedgerMaster.cpp 38.5% 8 Missing ⚠️
src/xrpld/perflog/detail/PerfLogImp.cpp 0.0% 8 Missing ⚠️
src/xrpld/app/misc/detail/ValidatorList.cpp 80.0% 5 Missing ⚠️
src/xrpld/overlay/detail/OverlayImpl.cpp 37.5% 5 Missing ⚠️
src/xrpld/peerfinder/detail/Logic.h 54.5% 5 Missing ⚠️
src/libxrpl/basics/Log.cpp 0.0% 4 Missing ⚠️
src/xrpld/app/main/Application.cpp 71.4% 4 Missing ⚠️
src/xrpld/app/misc/NetworkOPs.cpp 76.5% 4 Missing ⚠️
... and 73 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           release   #5212     +/-   ##
=========================================
- Coverage     77.9%   77.9%   -0.0%     
=========================================
  Files          784     784             
  Lines        66681   66681             
  Branches      8162    8138     -24     
=========================================
- Hits         51950   51939     -11     
- Misses       14731   14742     +11     
Files with missing lines Coverage Δ
include/xrpl/basics/Buffer.h 100.0% <100.0%> (ø)
include/xrpl/basics/SlabAllocator.h 94.6% <100.0%> (ø)
include/xrpl/basics/Slice.h 96.8% <100.0%> (ø)
include/xrpl/basics/partitioned_unordered_map.h 99.1% <100.0%> (ø)
include/xrpl/basics/random.h 100.0% <100.0%> (ø)
include/xrpl/basics/scope.h 100.0% <100.0%> (ø)
include/xrpl/basics/spinlock.h 93.5% <100.0%> (ø)
include/xrpl/beast/asio/io_latency_probe.h 96.8% <100.0%> (ø)
include/xrpl/beast/clock/manual_clock.h 100.0% <100.0%> (ø)
.../beast/container/detail/aged_unordered_container.h 96.5% <100.0%> (ø)
... and 234 more

... and 1 file with indirect coverage changes

Impacted file tree graph

@ximinez
Copy link
Collaborator Author

ximinez commented Dec 5, 2024

This PR is out of date. I'll open another one when I get it caught up.

@ximinez ximinez closed this Dec 5, 2024
@ximinez ximinez deleted the release-next branch December 6, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants