Antithesis instrumentation improvements

[Bronek]

High Level Overview of Change

Minor changes relating to feedback received late in #5042

Context of Change

• Rename ASSERT to XRPL_ASSERT
• Upgrade to Anthithesis SDK 0.4.4
• Use new 0.4.4 features
  • automatic cast to bool, like assert
• Add instrumentation workflow to verify build with instrumentation enabled

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Refactor (non-breaking change that only restructures code)
• Performance (increase or change in throughput and/or latency)
• Tests (you added tests for code that already exists, or your new feature included in this PR)
• Documentation update
• Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
• Release

[codecov]

Codecov Report

Attention: Patch coverage is 89.34531% with 83 lines in your changes missing coverage. Please review.

Project coverage is 77.9%. Comparing base (ea1fffe) to head (955ffec).
Report is 1 commits behind head on develop.

Files with missing lines	Patch %	Lines
src/xrpld/overlay/detail/PeerImp.cpp	0.0%	12 Missing ⚠️
src/xrpld/app/ledger/detail/LedgerMaster.cpp	41.7%	7 Missing ⚠️
src/xrpld/app/misc/detail/ValidatorList.cpp	80.0%	5 Missing ⚠️
src/xrpld/overlay/detail/OverlayImpl.cpp	37.5%	5 Missing ⚠️
src/xrpld/peerfinder/detail/Logic.h	60.0%	4 Missing ⚠️
include/xrpl/protocol/FeeUnits.h	0.0%	3 Missing ⚠️
src/libxrpl/protocol/Rate2.cpp	50.0%	3 Missing ⚠️
src/xrpld/app/ledger/LedgerHistory.cpp	76.9%	3 Missing ⚠️
src/xrpld/app/consensus/RCLConsensus.cpp	66.7%	2 Missing ⚠️
src/xrpld/app/ledger/ConsensusTransSetSF.cpp	0.0%	2 Missing ⚠️
... and 33 more

Additional details and impacted files

@@            Coverage Diff            @@
##           develop   #5213     +/-   ##
=========================================
- Coverage     77.9%   77.9%   -0.0%     
=========================================
  Files          783     783             
  Lines        66677   66677             
  Branches      8108    8108             
=========================================
- Hits         51921   51918      -3     
- Misses       14756   14759      +3     

Files with missing lines	Coverage Δ
include/xrpl/basics/Buffer.h	100.0% <100.0%> (ø)
include/xrpl/basics/SlabAllocator.h	94.6% <100.0%> (ø)
include/xrpl/basics/Slice.h	96.8% <100.0%> (ø)
include/xrpl/basics/partitioned_unordered_map.h	99.2% <100.0%> (ø)
include/xrpl/basics/random.h	100.0% <100.0%> (ø)
include/xrpl/basics/scope.h	100.0% <100.0%> (ø)
include/xrpl/basics/spinlock.h	93.5% <100.0%> (ø)
include/xrpl/beast/asio/io_latency_probe.h	96.8% <100.0%> (ø)
include/xrpl/beast/clock/manual_clock.h	100.0% <100.0%> (ø)
.../beast/container/detail/aged_unordered_container.h	96.5% <100.0%> (ø)
... and 203 more

... and 1 file with indirect coverage changes

[ximinez]

Man, I wish I could ignore the ASSERT -> XRPL_ASSERT changes the way I can ignore whitespace. This PR would be like 50 lines long.

[Bronek]

Man, I wish I could ignore the ASSERT -> XRPL_ASSERT changes the way I can ignore whitespace. This PR would be like 50 lines long.

You could repeat what I've done

for i in $(git grep -Hwn ASSERT | grep -oE '^[^.]+.(cpp|h|ipp)' | sort -u); do sed -i "s|\bASSERT\b|XRPL_ASSERT|g" "$i" && clang-format -i "$i"; done

... and then compare results.

[ximinez]

Looks good from here. There's a conflict that needs to be resolved, though.

[godexsoft]

Thanks for leaving ASSERT available for clients. This looks good from Clio's perspective 👍

[vvysokikh1]

lgtm