Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ledger RPC command response, type of ledger_index field #2920

Open
ckeshava opened this issue Dec 20, 2024 · 1 comment
Open

ledger RPC command response, type of ledger_index field #2920

ckeshava opened this issue Dec 20, 2024 · 1 comment

Comments

@ckeshava
Copy link
Contributor

In the response format of the ledger RPC command, I'd like to draw attention to the ledger_index field. The observed responses are of type string, however the documentation mentions Number as the expected type. It is possible that the type was updated in the APIv2 migration.

Please refer to the examples here: https://xrpl.org/resources/dev-tools/websocket-api-tool?server=wss%3A%2F%2Fs1.ripple.com%2F&req=%7B%20%20%22command%22%3A%20%22ledger%22%2C%0A%20%20%22ledger_index%22%3A%20%2292894212%22%2C%0A%20%20%22binary%22%3A%20true%0A%7D

@Bronek
Copy link

Bronek commented Dec 24, 2024

This was fixed in XRPLF/rippled#4820 , but the old behaviour is retained in API v1 (since it would be a breaking change). Please select API v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants