Consistently show ledger_index as integer on JSON output #4820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This resolves this issue: #3652 |
Bronek
force-pushed
the
feature/unify_json_ledger_index_int
branch
from
761104f to
4548a30
Compare
Bronek
force-pushed
the
feature/unify_json_ledger_index_int
branch
from
4548a30 to
7a1ab1f
Compare
May want to revert this commit, if we decide to keep it at API version 3
HowardHinnant
approved these changes
Nov 21, 2023
ximinez
approved these changes
Nov 21, 2023
Bronek
force-pushed
the
feature/unify_json_ledger_index_int
branch
from
b3cb87e to
ff9e616
Compare
8 tasks
Bronek
added a commit
to Bronek/rippled
that referenced
this pull request
Nov 22, 2023
|
@Bronek please update this PR so the change applies in api_version 2 |
|
We have this corresponding issue for Clio to maintain parity XRPLF/clio#1014 @Bronek @intelliot would be appreciated if we can have a rippled issue created with the API Change label in the future so we can catch these breaking API changes quicker for Clio folks to work on that side 🙏 |
sophiax851
pushed a commit
to sophiax851/rippled
that referenced
this pull request
Jun 12, 2024
For api_version 2, always return ledger_index as integer in JSON output. api_version 1 retains prior behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Several methods in API version 1 return
ledger_indexas a quoted number, i.e. string type. This value should be consistently returned as a number. It was reported in XRPLF/clio#722 (comment) and I missed it in earlier changes meant for API version 2Context of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)Before / After
Before:
JSON output from
ledgerwould contain ledger as string e.g."ledger_index": "54300932"After
JSON output from
ledgerwould contain ledger as number e.g."ledger_index": 54300932