Shards updates for v1.8.0 #1249
Conversation
mDuo13
added
new topic
|
Link check report. 339245 links checked. Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/shards_180/ |
There was a problem hiding this comment.
I'm not the expert on this, but it all looks right to me. I did have one suggestion which you can take or leave.
@undertome, could you review this as well?
| | `complete_shards` | String | The range of history shards this peer has available. This may be disjointed. For example, `1-2,5,7-9` indicates that shards 1, 2, 5, 7, 8, and 9 are available. | | ||
| | `ip` | String | _(May be omitted)_ The IP address of the peer this object describes. This may be an IPv4 or IPv6 address. Omitted if this is a [private peer](peer-protocol.html#private-peers). | | ||
| | `complete_shards` | String | The range of complete history shards this peer has available. This may be disjointed. For example, `1-2,5,7-9` indicates that shards 1, 2, 5, 7, 8, and 9 are available. | | ||
| | `incomplete_shards` | String | _(May be omitted)_ A comma-separated list of history shards this peer has partially downloaded, and percent completion for each. For example, `1:50,2:25` indicates that shard 1 is 50% downloaded and shard 2 is 25% downloaded. [New in: rippled 1.8.0][] | |
There was a problem hiding this comment.
Yup, as far as I can tell this is correct.
| - Data Retention | ||
| --- | ||
| # node_to_shard | ||
| [[Source]](https://github.com/undertome/rippled/blob/develop/src/ripple/rpc/handlers/NodeToShard.cpp "Source") |
There was a problem hiding this comment.
This source address should probably be moved to the main rippled repository? Possibly this: https://github.com/ripple/rippled/blob/develop/src/ripple/rpc/handlers/NodeToShard.cpp
|
Link check report. 339245 links checked. Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/shards_180/ |
Documents XRPLF/rippled#3875, XRPLF/rippled#3595, and XRPLF/rippled#3726
crawl_shardscommandnode_to_shardcommand