Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Porting Clawback documentation to xrpl.org #2111

Merged
merged 9 commits into from
Sep 11, 2023
Merged

Porting Clawback documentation to xrpl.org #2111

merged 9 commits into from
Sep 11, 2023

Conversation

amarantha-k
Copy link
Collaborator

Documentation for the new Clawback transaction (XRPLF/rippled#4553)

@amarantha-k amarantha-k mentioned this pull request Sep 6, 2023
Closed
@amarantha-k amarantha-k requested a review from oeggert September 6, 2023 21:27
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Link check report. 525132 links checked.
Success! No broken links found.

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/clawback-docs/

Style Report

DennisDawson
DennisDawson approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@DennisDawson DennisDawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a couple of quick edits. Trust lines is two words (I think that was a residual error I had made). There was a redundant from.

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Link check report. 525132 links checked.
Success! No broken links found.

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/clawback-docs/

Style Report

1 similar comment
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Link check report. 525132 links checked.
Success! No broken links found.

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/clawback-docs/

Style Report

oeggert
oeggert approved these changes Sep 6, 2023
View reviewed changes
Copy link
Collaborator

@oeggert oeggert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

mDuo13
mDuo13 requested changes Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@mDuo13 mDuo13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to modify the AccountSet transaction reference to add the relevant changes:

  • asfAllowClawback (value 16) in the "AccountSet Flags" section
  • New error cases, for situations where you tried to enable Allow Clawback but couldn't for various reasons like already having No Freeze enabled

Also need to modify the AccountRoot ledger entry reference:

  • Add lsfClawback (value 0x80000000 / 2147483648) to the table of AccountRoot flags.

Add the missing snippet re: clawback, which may also need to be updated to reflect the 1.12.0 release.

Various other stuff noted in the comments below

content/concepts/tokens/clawback-of-issued-currency.md Outdated Show resolved Hide resolved
content/concepts/tokens/clawback-of-issued-currency.md Outdated Show resolved Hide resolved
content/concepts/tokens/clawback-of-issued-currency.md Outdated Show resolved Hide resolved
content/concepts/tokens/clawback-of-issued-currency.md Outdated Show resolved Hide resolved
content/concepts/tokens/clawback-of-issued-currency.md Outdated Show resolved Hide resolved
content/concepts/tokens/clawback-of-issued-currency.md Outdated Show resolved Hide resolved
content/references/protocol-reference/transactions/transaction-types/clawback.md Outdated Show resolved Hide resolved
content/references/protocol-reference/transactions/transaction-types/clawback.md Outdated Show resolved Hide resolved
content/concepts/tokens/clawback-of-issued-currency.md Outdated Show resolved Hide resolved
content/references/protocol-reference/transactions/transaction-types/clawback.md Outdated Show resolved Hide resolved
@mDuo13 mDuo13 added this to the rippled 1.12.0 milestone Sep 7, 2023
mDuo13
mDuo13 approved these changes Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@mDuo13 mDuo13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed one formatting issue but otherwise looks good

content/references/protocol-reference/ledger-data/ledger-object-types/accountroot.md Outdated
Comment on lines 73 to 74
`lsfAllowTrustLineClawback` | `0x80000000` | 2147483648 |
`asfAllowTrustLineClawback` | Enable [Clawback](clawing-back-tokens.html) for this account. |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines need to be combined to make the table display properly.

Suggested change
`lsfAllowTrustLineClawback` | `0x80000000` | 2147483648 |
`asfAllowTrustLineClawback` | Enable [Clawback](clawing-back-tokens.html) for this account. |
| `lsfAllowTrustLineClawback` | `0x80000000` | 2147483648 | `asfAllowTrustLineClawback` | Enable [Clawback](clawing-back-tokens.html) for this account. |

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Link check report. 528587 links checked.
1 broken links found:
File: out/accountset.html Link: [Clawback amendment][]

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/clawback-docs/

Style Report

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Link check report. 538176 links checked.
Success! No broken links found.

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/clawback-docs/

Style Report

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Link check report. 538177 links checked.
Success! No broken links found.

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/clawback-docs/

Style Report

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Link check report. 538177 links checked.
Success! No broken links found.

Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/clawback-docs/

Style Report

@mDuo13 mDuo13 mentioned this pull request Sep 11, 2023
Merged
@mDuo13 mDuo13 merged commit c211bcf into master Sep 11, 2023
@mDuo13 mDuo13 deleted the clawback-docs branch September 11, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mDuo13 mDuo13 mDuo13 approved these changes

@DennisDawson DennisDawson DennisDawson approved these changes

@oeggert oeggert oeggert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
rippled 1.12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@amarantha-k @DennisDawson @mDuo13 @oeggert