Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LastUpdateTime description in oracleset.md #2837

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

pkcs8
Copy link
Contributor

@pkcs8 pkcs8 commented Nov 1, 2024

Updated description for LastUpdateTime field as per the PriceOracle PR comments. This field accepts UNIX time instead of Ripple time because it must integrate with third party systems that may not measure time in Ripple time.

Updated description for `LastUpdateTime` field as per the (PR comments)[XRPLF/rippled#4789 (review)]. This field accepts UNIX time instead of Ripple time because it must integrate with third party systems that may not measure time in Ripple time.
@pkcs8 pkcs8 changed the title Update oracleset.md Update LastUpdateTime description in oracleset.md Nov 1, 2024
@tequdev tequdev linked an issue Nov 3, 2024 that may be closed by this pull request
@amarantha-k amarantha-k requested a review from oeggert November 4, 2024 18:24
Copy link
Collaborator

@oeggert oeggert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@oeggert oeggert merged commit 041e991 into XRPLF:master Nov 4, 2024
2 checks passed
@tequdev tequdev added the needs japanese translation PRs with English changes that need to be added/updated in the Japanese translation of the site label Nov 12, 2024
@tequdev tequdev removed the needs japanese translation PRs with English changes that need to be added/updated in the Japanese translation of the site label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LastUpdateTime field in OracleSet must be specified in Unixtime.
3 participants