Changing pubkey to public_key #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing `pubkey` as a request parameter doesn't do anything. We need to pass in `public_key` to get the desired result
|
Good catch. I was fooled by an inaccurate comment in the code, but you're right, it's actually public_key. |
mDuo13
approved these changes
Jun 11, 2020
mDuo13
added a commit
to XRPLF/rippled
that referenced
this pull request
Jun 11, 2020
Corrects the public_key parameter name in the comment. See XRPLF/xrpl-dev-portal#854 for context.
manojsdoshi
pushed a commit
to manojsdoshi/rippled
that referenced
this pull request
Jun 16, 2020
Corrects the public_key parameter name in the comment. See XRPLF/xrpl-dev-portal#854 for context.
manojsdoshi
pushed a commit
to manojsdoshi/rippled
that referenced
this pull request
Jun 24, 2020
Corrects the public_key parameter name in the comment. See XRPLF/xrpl-dev-portal#854 for context.
manojsdoshi
pushed a commit
to manojsdoshi/rippled
that referenced
this pull request
Jun 24, 2020
Corrects the public_key parameter name in the comment. See XRPLF/xrpl-dev-portal#854 for context.
manojsdoshi
pushed a commit
to manojsdoshi/rippled
that referenced
this pull request
Jun 25, 2020
Corrects the public_key parameter name in the comment. See XRPLF/xrpl-dev-portal#854 for context.
manojsdoshi
pushed a commit
to manojsdoshi/rippled
that referenced
this pull request
Jun 25, 2020
Corrects the public_key parameter name in the comment. See XRPLF/xrpl-dev-portal#854 for context.
manojsdoshi
pushed a commit
to manojsdoshi/rippled
that referenced
this pull request
Jun 25, 2020
Corrects the public_key parameter name in the comment. See XRPLF/xrpl-dev-portal#854 for context.
manojsdoshi
pushed a commit
to manojsdoshi/rippled
that referenced
this pull request
Jun 25, 2020
Corrects the public_key parameter name in the comment. See XRPLF/xrpl-dev-portal#854 for context.
manojsdoshi
pushed a commit
to manojsdoshi/rippled
that referenced
this pull request
Jun 29, 2020
Corrects the public_key parameter name in the comment. See XRPLF/xrpl-dev-portal#854 for context.
manojsdoshi
pushed a commit
to manojsdoshi/rippled
that referenced
this pull request
Jun 29, 2020
Corrects the public_key parameter name in the comment. See XRPLF/xrpl-dev-portal#854 for context.
manojsdoshi
pushed a commit
to manojsdoshi/rippled
that referenced
this pull request
Jun 30, 2020
Corrects the public_key parameter name in the comment. See XRPLF/xrpl-dev-portal#854 for context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing
pubkeyas a request parameter doesn't do anything. We need to pass inpublic_keyto get the desired result.