Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health Check method #862

Merged
merged 5 commits into from
Jul 13, 2020
Merged

Health Check method #862

merged 5 commits into from
Jul 13, 2020

Conversation

mDuo13
Copy link
Collaborator

@mDuo13 mDuo13 commented Jun 30, 2020

  • Documents Create health_check rpc rippled#3365
  • Groups the "Peer Crawler" and "Validator List" methods along with the new Health Check method into a "Peer Port Methods" category under the rippled APIs heading. Previously the two special methods were stand-alone entries at this level, but three's a crowd so now I've grouped them into a category. The pages' URLs have not changed.
  • Clarifies nightly/unstable installs & cleans up some language regarding parallel networks.
  • Adds more detail to network bandwidth section of Capacity Planning

The current version of the health check method should be mostly¹ accurate as of v1.6.0-b8. However, I have reported a bug & suggested some changes that I hope may get into the release version. These docs will have to be updated if my suggested changes get applied.

¹ I say "mostly" because the docs don't note the main load_factor bug that causes the method to always report a warning...

@mDuo13 mDuo13 changed the title Health Check method: set up IA Health Check method Jul 6, 2020
@mDuo13 mDuo13 marked this pull request as ready for review July 6, 2020 23:27
@mDuo13 mDuo13 requested a review from HowardHinnant July 6, 2020 23:27
@HowardHinnant
Copy link

Here's the PR to address the suggested changes: XRPLF/rippled#3491

Copy link

@lrenazhou1010 lrenazhou1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great doc Rome! Left a few comments/suggestions

mDuo13 added 2 commits July 8, 2020 13:39
@mDuo13 mDuo13 merged commit cbf104f into XRPLF:v1.6.0 Jul 13, 2020
@mDuo13 mDuo13 deleted the health_check_method branch July 13, 2020 17:58
@mDuo13
Copy link
Collaborator Author

mDuo13 commented Jul 13, 2020

Broken links include:

  • wikipedia Base58 page (recently deleted for "lack of notability"). We'll have to replace this link, but that's outside the scope of this task.
  • Some GitHub links that appear to have recovered
  • v1.6.0 tag (expected to be broken until the release is ready)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants