Skip to content

Commit

Permalink
Add include_deleted param to ledger_entry API (#721)
Browse files Browse the repository at this point in the history
* add nfts_by_issuer

* update Changelog

* added nfts_by_issuer to Request's get_method

* reformat changelog and add required comment for nfts_by_issuer.py

* add include_delete field

* update change log

* another conflict fixed

* add a comment

* fix a style issue

* changed to more descriptive comment

* update CHANGELOG

---------

Co-authored-by: Kassaking <[email protected]>
Co-authored-by: Chenna Keshava B S <[email protected]>
Co-authored-by: Mayukha Vadari <[email protected]>
  • Loading branch information
4 people authored Oct 26, 2024
1 parent fd278e0 commit 00c90db
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [[Unreleased]]

### Added
- Add `include_deleted` to ledger_entry request

### BREAKING CHANGE:
- Remove Python 3.7 support to fix dependency installation and use 3.8 as new default.

Expand Down
2 changes: 2 additions & 0 deletions xrpl/models/requests/ledger_entry.py
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,8 @@ class LedgerEntry(Request, LookupByLedgerRequest):
binary: bool = False
nft_page: Optional[str] = None
"""Must be the object ID of the NFToken page, as hexadecimal"""
include_deleted: Optional[bool] = None
"""This parameter is supported only by Clio servers"""

def _get_errors(self: Self) -> Dict[str, str]:
errors = super()._get_errors()
Expand Down

0 comments on commit 00c90db

Please sign in to comment.