Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ExpandedSignerList amendment support #406

Merged
merged 12 commits into from
Sep 13, 2022
Merged

Conversation

khancode
Copy link
Collaborator

@khancode khancode commented Jun 15, 2022

High Level Overview of Change

Adds ExpandedSignerList amendment support.

Context of Change

  • Expands the maximum signer list size to 32 entries.
  • Adds an optional field wallet_locator to SignerEntry.
  • rippled PR

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

Test Plan

Adds unit & integration tests.

Future Tasks

Merge this PR once the amendment goes live.

@khancode khancode requested review from ckniffen and JST5000 June 15, 2022 21:50
Copy link
Contributor

@JST5000 JST5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after adding that test case :)

Copy link
Collaborator

@intelliot intelliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Expected error if someone tries to set too many signers (before amendment is enabled): temDISABLED
  • Some test networks could activate the amendment before Mainnet
  • Should be fine to merge and release at any time (so it's ready if/when the amendment activates)

@khancode khancode merged commit dd9d024 into master Sep 13, 2022
@khancode khancode deleted the expanded-signer-list branch September 13, 2022 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants