-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature NetworkID
#520
feature NetworkID
#520
Conversation
Usage: https://github.com/Transia-RnD/xls-playground/blob/main/py/tests/test_xls_network_id.py
|
@dangell7 wanted to check back on this work |
The js repo wanted to handle it a bit differently, I can see if there is are any other changes they want to make to the PR and then I can attempt to do the same here. JS PR: XRPLF/xrpl.js#2216 |
Hi @dangell7, do you want to work on this PR on your own or may I just take over this as well (if so could you invite me to this repo as well?) Thank you! |
Added you to this repo :) |
High Level Overview of Change
XRPLF/rippled#4370
Context of Change
Added network id to the base transaction
Added network id to the
server_info
responseAdded network id to the binary codec
Added network id to autofill if custom network id was supplied to client.
Type of Change
Test Plan
No tests were written