Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature NetworkID #520

Merged
merged 17 commits into from
Jun 16, 2023
Merged

feature NetworkID #520

merged 17 commits into from
Jun 16, 2023

Conversation

dangell7
Copy link
Contributor

@dangell7 dangell7 commented Feb 17, 2023

High Level Overview of Change

XRPLF/rippled#4370

Context of Change

Added network id to the base transaction
Added network id to the server_info response
Added network id to the binary codec
Added network id to autofill if custom network id was supplied to client.

Type of Change

  • New feature (non-breaking change which adds functionality)

Test Plan

No tests were written

@dangell7 dangell7 changed the title Add Network ID feature NetworkID Feb 17, 2023
@dangell7 dangell7 changed the title feature NetworkID [DO NOT MERGE] feature NetworkID Feb 17, 2023
@dangell7 dangell7 changed the title [DO NOT MERGE] feature NetworkID feature NetworkID Feb 24, 2023
@dangell7 dangell7 marked this pull request as ready for review February 24, 2023 21:39
@dangell7
Copy link
Contributor Author

Usage: https://github.com/Transia-RnD/xls-playground/blob/main/py/tests/test_xls_network_id.py

client.network_id = get_network_id(client)

@dangell7 dangell7 closed this Mar 28, 2023
@dangell7 dangell7 reopened this Mar 29, 2023
@dangell7 dangell7 marked this pull request as draft March 29, 2023 17:08
@justinr1234
Copy link
Collaborator

@dangell7 wanted to check back on this work

@dangell7
Copy link
Contributor Author

@dangell7 wanted to check back on this work

The js repo wanted to handle it a bit differently, I can see if there is are any other changes they want to make to the PR and then I can attempt to do the same here.

JS PR: XRPLF/xrpl.js#2216

@pdp2121
Copy link
Collaborator

pdp2121 commented May 30, 2023

@dangell7 wanted to check back on this work

The js repo wanted to handle it a bit differently, I can see if there is are any other changes they want to make to the PR and then I can attempt to do the same here.

JS PR: XRPLF/xrpl.js#2216

Hi @dangell7, do you want to work on this PR on your own or may I just take over this as well (if so could you invite me to this repo as well?) Thank you!

@dangell7
Copy link
Contributor Author

@dangell7 wanted to check back on this work

The js repo wanted to handle it a bit differently, I can see if there is are any other changes they want to make to the PR and then I can attempt to do the same here.
JS PR: XRPLF/xrpl.js#2216

Hi @dangell7, do you want to work on this PR on your own or may I just take over this as well (if so could you invite me to this repo as well?) Thank you!

Added you to this repo :)

@pdp2121 pdp2121 marked this pull request as ready for review June 13, 2023 00:17
@pdp2121 pdp2121 merged commit 972177d into XRPLF:master Jun 16, 2023
@dangell7 dangell7 deleted the network-id branch October 7, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants