Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add disallow_incoming flags #522

Merged
merged 4 commits into from
Feb 21, 2023
Merged

Add disallow_incoming flags #522

merged 4 commits into from
Feb 21, 2023

Conversation

JST5000
Copy link
Contributor

@JST5000 JST5000 commented Feb 18, 2023

High Level Overview of Change

Adding support for this amendment XRPLF/rippled#4336

Context of Change

Title says it all

Type of Change

  • New feature (non-breaking change which adds functionality)

Test Plan

CI Passes

ckniffen
ckniffen reviewed Feb 21, 2023
View reviewed changes
xrpl/models/flags.py Outdated Show resolved Hide resolved
ckniffen
ckniffen requested changes Feb 21, 2023
View reviewed changes
Copy link
Collaborator

@ckniffen ckniffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove from TX_FLAGS

@JST5000 JST5000 requested a review from ckniffen February 21, 2023 23:04
@JST5000 JST5000 merged commit ef0a606 into master Feb 21, 2023
@JST5000 JST5000 deleted the add-flags branch February 21, 2023 23:33
@rikublock rikublock mentioned this pull request Mar 13, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khancode khancode khancode approved these changes

@ckniffen ckniffen ckniffen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JST5000 @ckniffen @khancode