Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rectify flag name TF_NO_RIPPLE_DIRECT #691

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Rectify flag name TF_NO_RIPPLE_DIRECT #691

merged 2 commits into from
Mar 20, 2024

Conversation

ckeshava
Copy link
Collaborator

High Level Overview of Change

Rectify the incorrect usage of the transaction flag from TF_NO_DIRECT_RIPPLE to TF_NO_RIPPLE_DIRECT

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

Did you update CHANGELOG.md?

  • Yes
  • No, this change does not impact library users

Test Plan

Updated the tests to use the new flag name

@ckeshava ckeshava requested review from JST5000 and pdp2121 February 20, 2024 22:20
@pdp2121
Copy link
Collaborator

pdp2121 commented Feb 22, 2024

Is it also a breaking change? If so, please reflect on CHANGELOG

@ckeshava
Copy link
Collaborator Author

Hello @pdp2121 , I have included a line in the CHANGELOG. Do you want me to re-word that?

@ckeshava ckeshava merged commit 5d6cf49 into main Mar 20, 2024
21 checks passed
@ckeshava ckeshava deleted the rectifyFlagName branch March 20, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants