-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support featureXRPFees
amendment
#2219
Labels
Comments
2 tasks
ckniffen
added a commit
that referenced
this issue
Jun 29, 2023
Adds the new fields for `XRPFees` amendment and id for the `FeeSettings` singleton ledger entry. Closes #2219
2 tasks
ckniffen
added a commit
that referenced
this issue
Jun 29, 2023
Adds the new fields for `XRPFees` amendment and id for the `FeeSettings` singleton ledger entry. Closes #2219
ckniffen
added a commit
that referenced
this issue
Jul 3, 2023
Adds the new fields for `XRPFees` amendment and id for the `FeeSettings` singleton ledger entry. Closes #2219
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This amendment is part of [email protected] and updates the fees to be formatted as Amounts.
XRPLF/rippled#4247
For server_info favor the following in orderreserve_base_drops
,reserve_base
,reserve_base_xrp
base_fee_drops
,base_fee
,base_fee_xrp
reserve_inc_drops
,reserve_inc_fee
,reserve_inc_fee_xrp
If specifically looking for fees such as in the client libraries when autofilling use the commandfee
which is not changed by this PR and is already in drops.Validations processing will need to be handled similar toserver_info
.Fee
property on all transactions remains the sameSetFee
transactionsBaseFeeDrops
,ReserveBaseDrops
, andReserveIncrementDrops
will be present when the amendment is passed and on new transactions. These will be of the type AmountBaseFee
,ReserveBase
,ReferenceFeeUnits
,ReserveIncrement
are valid only historically after the amendment passesThe text was updated successfully, but these errors were encountered: