Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove extra lock files and nyc #2403

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

ckniffen
Copy link
Collaborator

High Level Overview of Change

nyc is not a direct dependency any more and nested lock files are unused

Type of Change

  • New feature (non-breaking change which adds functionality)

nyc is not a direct dependency any more and nested lock files are unused
@socket-security
Copy link

Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
ripple-keypairs 1.1.5...1.3.0 None +0/-1 29.6 kB jst5000
ws 8.12.1...8.13.0 None +0/-0 137 kB lpinca
karma-chrome-launcher 3.1.1...3.2.0 environment +0/-0 29.6 kB karmarunnerbot

🚮 Removed packages: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]

@ckniffen
Copy link
Collaborator Author

You can see above that socket security got confused by the multiple package-lock files.

xrpl-grants

This comment was marked as outdated.

Copy link
Contributor

@JST5000 JST5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ckniffen ckniffen merged commit f760b2e into main Jul 20, 2023
@ckniffen ckniffen deleted the feature/remove-extra-package-lock branch July 20, 2023 20:03
ckniffen added a commit that referenced this pull request Jul 25, 2023
* fix: escrow finish and cancel integration (#2382)

* fix: escrow finish and cancel integration

* add docs

* Update docker to xrpllabsofficial/xrpld:1.12.0-b1 (#2381)

* release 2.9.1 (#2391)

* build(deps-dev): bump word-wrap from 1.2.3 to 1.2.4 (#2392)

Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4.
- [Release notes](https://github.com/jonschlinkert/word-wrap/releases)
- [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4)

---
updated-dependencies:
- dependency-name: word-wrap
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: add Clawback amendment support (#2353)

* Add Clawback transaction
* Account flag lsfAllowTrustLineClawback
* Support bitwise flag checking of 64 bit flags

* build(deps-dev): bump ts-jest from 29.1.0 to 29.1.1 (#2396)

* build(deps-dev): bump ts-loader from 9.4.2 to 9.4.4 (#2395)

Bumps [ts-loader](https://github.com/TypeStrong/ts-loader) from 9.4.2 to 9.4.4.
- [Release notes](https://github.com/TypeStrong/ts-loader/releases)
- [Changelog](https://github.com/TypeStrong/ts-loader/blob/main/CHANGELOG.md)
- [Commits](TypeStrong/ts-loader@v9.4.2...v9.4.4)

---
updated-dependencies:
- dependency-name: ts-loader
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps-dev): bump source-map-loader from 3.0.2 to 4.0.1 (#2399)

* build(deps-dev): bump url from 0.11.0 to 0.11.1 (#2400)

Bumps [url](https://github.com/defunctzombie/node-url) from 0.11.0 to 0.11.1.
- [Commits](defunctzombie/node-url@v0.11.0...v0.11.1)

---
updated-dependencies:
- dependency-name: url
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps-dev): bump jest and @types/jest (#2397)

Bumps [jest](https://github.com/facebook/jest/tree/HEAD/packages/jest) and [@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest). These dependencies needed to be updated together.

Updates `jest` from 29.5.0 to 29.6.1
- [Release notes](https://github.com/facebook/jest/releases)
- [Changelog](https://github.com/jestjs/jest/blob/main/CHANGELOG.md)
- [Commits](https://github.com/facebook/jest/commits/v29.6.1/packages/jest)

Updates `@types/jest` from 29.5.1 to 29.5.3
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest)

---
updated-dependencies:
- dependency-name: jest
  dependency-type: direct:development
  update-type: version-update:semver-minor
- dependency-name: "@types/jest"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Caleb Kniffen <[email protected]>

* chore: remove extra lock files and `nyc` (#2403)

nyc is not a direct dependency any more and nested lock files are unused

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: justinr1234 <[email protected]>
Co-authored-by: Shawn Xie <[email protected]>
Co-authored-by: pdp2121 <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants