Add support for featureDisallowIncoming amendment #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eDisallowIncoming amendment
nkramer44
requested review from
mukulljangid and
sappenin
and removed request for
sappenin and
nhartner
Codecov Report
@@ Coverage Diff @@
## main #419 +/- ##
============================================
+ Coverage 90.03% 90.09% +0.05%
- Complexity 1376 1385 +9
============================================
Files 266 268 +2
Lines 4003 4027 +24
Branches 332 332
============================================
+ Hits 3604 3628 +24
Misses 279 279
Partials 120 120
|
sappenin
requested changes
Jun 14, 2023
...4j-integration-tests/src/test/java/org/xrpl/xrpl4j/tests/environment/MainnetEnvironment.java
Outdated
Show resolved
Hide resolved
xrpl4j-core/src/test/java/org/xrpl/xrpl4j/model/flags/AccountRootFlagsTests.java
Show resolved
Hide resolved
…encounter an unsupported ledger object.
…o fill a JsonNode field. Also figured out that setting `visible = true` on `@JsonTypeInfo` includes the TypeID in the deserializer.
sappenin
reviewed
Jun 21, 2023
xrpl4j-integration-tests/src/test/java/org/xrpl/xrpl4j/tests/AccountTransactionsIT.java
Outdated
Show resolved
Hide resolved
sappenin
reviewed
Jun 21, 2023
...4j-integration-tests/src/test/java/org/xrpl/xrpl4j/tests/environment/MainnetEnvironment.java
Outdated
Show resolved
Hide resolved
sappenin
reviewed
Jun 21, 2023
...4j-integration-tests/src/test/java/org/xrpl/xrpl4j/tests/environment/MainnetEnvironment.java
Outdated
Show resolved
Hide resolved
sappenin
reviewed
Jun 21, 2023
xrpl4j-integration-tests/src/test/java/org/xrpl/xrpl4j/tests/AccountTransactionsIT.java
Outdated
Show resolved
Hide resolved
…untrootFlagsTests
…ithub actions workflow to run ITs against testnet clio
sappenin
reviewed
Jun 22, 2023
...4j-integration-tests/src/test/java/org/xrpl/xrpl4j/tests/environment/MainnetEnvironment.java
Outdated
Show resolved
Hide resolved
sappenin
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
DisallowIncomingamendment that was recently activated on mainnet. See this PR for more details on the amendment.Also fixes #423 by adding
UnknownLedgerObjectand using it as thedefaultImplin theLedgerObject@JsonTypeInfoannotation. A PR was recently merged and deployed to devnet/testnet that addsNFTokenPages to the response ofaccount_objects. We do not have a mapping forNFTokenPagein xrpl4j yet, so addingUnknownLedgerObjectwas necessary to get devnet/testnet ITs to pass.