Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add objects for NFTokenPages #432

Merged
merged 28 commits into from
Jul 7, 2023
Merged

Add objects for NFTokenPages #432

merged 28 commits into from
Jul 7, 2023

Conversation

nkramer44
Copy link
Collaborator

Fixes #430 and #431

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #432 (185a59d) into main (1d34a3e) will increase coverage by 0.24%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #432      +/-   ##
============================================
+ Coverage     90.30%   90.54%   +0.24%     
- Complexity     1432     1452      +20     
============================================
  Files           277      281       +4     
  Lines          4125     4147      +22     
  Branches        339      339              
============================================
+ Hits           3725     3755      +30     
+ Misses          279      271       -8     
  Partials        121      121              
Impacted Files Coverage Δ
...pl/xrpl4j/model/client/accounts/NfTokenObject.java 100.00% <ø> (ø)
...rg/xrpl/xrpl4j/model/transactions/NfTokenMint.java 100.00% <ø> (ø)
...rpl4j/model/client/accounts/AccountNftsResult.java 87.50% <100.00%> (+70.83%) ⬆️
...l/client/accounts/AccountObjectsRequestParams.java 100.00% <100.00%> (+22.22%) ⬆️
...java/org/xrpl/xrpl4j/model/flags/NfTokenFlags.java 100.00% <100.00%> (ø)
...odel/jackson/modules/AffectedNodeDeserializer.java 100.00% <100.00%> (ø)
...j/model/jackson/modules/TransferFeeSerializer.java 100.00% <100.00%> (ø)
...ava/org/xrpl/xrpl4j/model/ledger/LedgerObject.java 84.00% <100.00%> (+0.66%) ⬆️
...ain/java/org/xrpl/xrpl4j/model/ledger/NfToken.java 100.00% <100.00%> (ø)
...rg/xrpl/xrpl4j/model/ledger/NfTokenPageObject.java 100.00% <100.00%> (ø)
... and 2 more

Base automatically changed from nk/tx-metadata to main June 29, 2023 19:24
@nkramer44 nkramer44 requested a review from sappenin July 5, 2023 17:10
@nkramer44 nkramer44 merged commit 7eaaed1 into main Jul 7, 2023
@nkramer44 nkramer44 deleted the nk/add-nftoken-page branch July 7, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add NFTokenPage Object
2 participants