Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SubmitPaymentIT
andTransactUsingDerivedKeySignatureServiceIT
both use hard-coded source accounts to send transactions. In these tests, we fund the source account, getaccount_info
for the account to get the account's sequence, and submit a transaction. This is fine when running ITs against a standalone rippled node, and even when running against a real network like testnet or devnet. However, our CI builds run in parallel, and we have more than one CI build running against testnet (reporting mode and clio mode). This sometimes results in test failures in these ITs due to getting atefPAST_SEQ
error when submitting the transaction. This happens because one test run submits its transaction between the time that the other test run gets the account's sequence and submits its transaction.The fix here is simply to use random or non-deterministic keypairs/accounts in these tests.