Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed module not found error in Dockerfile + Misc updates #15

Merged
merged 3 commits into from
Jul 13, 2022

Conversation

codecakes
Copy link
Contributor

@codecakes codecakes commented Jul 11, 2022

Fixes issue with running docker on this project. docker compose up --build works now.

  • updated Readme
  • removed unnecessary code in init.
  • Upgraded pylint version.
  • generated new pylintrc because of this PR

…d unnecessary code in init. Upgraded pylint version. generated new pylintrc
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jul 11, 2022

Sourcery Code Quality Report

This PR has an average code quality of %

Quality metrics Before After Change
Complexity 0.00 ⭐
Method Length 35.00 ⭐
Working memory 4.00 ⭐
Quality 93.19% % %
Other metrics Before After Change
Lines 6 0 -6
Changed files Quality Before Quality After Quality Change
registrations/init.py 93.19% ⭐ % %

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

Dockerfile Outdated
#WORKDIR /app

COPY registrations /app
ADD registrations /app/registrations
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DL3020: Use COPY instead of ADD for files and folders

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

@codecakes codecakes marked this pull request as ready for review July 11, 2022 19:19
@codecakes codecakes added bug Something isn't working documentation Improvements or additions to documentation security vulnerability Security vulnerability detected by WhiteSource security fix Security fix generated by WhiteSource infrastructure dependencies Pull requests that update a dependency file labels Jul 11, 2022
@codecakes codecakes self-assigned this Jul 11, 2022
@codecakes codecakes linked an issue Jul 13, 2022 that may be closed by this pull request
@codecakes codecakes removed a link to an issue Jul 13, 2022
Copy link
Collaborator

@Matt-Murungi Matt-Murungi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my understanding, the issue was that the "registration" module was not being found every time one would try to build the docker image.

I tried it on my local and it worked. So LGTM @codecakes

@codecakes
Copy link
Contributor Author

Thanks @Matt-Murungi could you approve?

From my understanding, the issue was that the "registration" module was not being found every time one would try to build the docker image.

I tried it on my local and it worked. So LGTM @codecakes

Copy link

@mmurungi mmurungi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecakes codecakes merged commit 77dd3f6 into develop Jul 13, 2022
@codecakes codecakes deleted the bug/fix-docker-module-not-found branch July 13, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation infrastructure security fix Security fix generated by WhiteSource security vulnerability Security vulnerability detected by WhiteSource
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants