Refactor generate method #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decompose the conditionals of the `$method` by extracting it into two methods. This way the `MethodNotFoundException` becomes redundant because each condition is explicitly handled by its corresponding method. Also the `generate` method has fewer responsibilities and is way simpler.
Xethron
reviewed
Dec 29, 2016
| foreach ( $tables as $table ) { | ||
| $this->table = $table; | ||
| $this->migrationName = 'create_'. $this->table .'_table'; | ||
| $this->fields = $this->schemaGenerator->getFields( $this->table ); |
There was a problem hiding this comment.
Shouldn't this one also call $this->generate()?
There was a problem hiding this comment.
Yes it should! My bad.
There was a problem hiding this comment.
Do you want me to fix this? Or would you like to?
|
Love it! Will test it out when I have a moment |
|
I'm glad you like it! But I should write some unit tests. I'll try to push them ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decompose the conditionals of the
$methodby extracting it into twomethods.
This way the
MethodNotFoundExceptionbecomes redundant because eachcondition is explicitly handled by its corresponding method.
Also the
generatemethod has fewer responsibilities and is waysimpler.