Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPX-01 add verification of vote signer belonging to masternodes #498

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

wgr523
Copy link
Collaborator

@wgr523 wgr523 commented Mar 19, 2024

Proposed changes

PPX-01 add verification of vote signer belonging to masternodes.

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

@gzliudan
Copy link
Collaborator

Shall we let the function verifyVotes return error and check it in the function voteHandler ?

Copy link
Collaborator

@liam-lai liam-lai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better change at VerifyVoteMessage function to stop candidate but not masternodes write as signer.

@wgr523
Copy link
Collaborator Author

wgr523 commented Apr 1, 2024

Shall we let the function verifyVotes return error and check it in the function voteHandler ?

the code changed is inside a go routine. the action inside the routine should be clearing the signature. after that, subsequent function can return error if the signature is empty, or not use that vote in a QC.

@wgr523 wgr523 merged commit c16bd66 into dev-upgrade Apr 1, 2024
34 checks passed
@wgr523 wgr523 deleted the ppx-01 branch April 1, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants