Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge from master for reorg bug fix #593

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

liam-lai
Copy link
Collaborator

@liam-lai liam-lai commented Jul 29, 2024

Proposed changes

Merge from master for reorg bug fix

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

gzliudan and others added 2 commits July 27, 2024 07:16
* params: fix usage of IsXDCxDisable

* internal/ethapi: fix nil block in function DoCall during reorg
@liam-lai liam-lai merged commit 4b35f33 into dev-upgrade Jul 29, 2024
18 checks passed
@liam-lai liam-lai deleted the merge-from-master-for-reorg-issue branch July 29, 2024 14:19
wanwiset25 pushed a commit that referenced this pull request Jul 30, 2024
* params: fix usage of IsXDCxDisable

* internal/ethapi: fix nil block in function DoCall during reorg

Co-authored-by: Daniel Liu <[email protected]>
wanwiset25 pushed a commit that referenced this pull request Aug 23, 2024
* params: fix usage of IsXDCxDisable

* internal/ethapi: fix nil block in function DoCall during reorg

Co-authored-by: Daniel Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants