Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[81_9] Hide tabbar when user chooses 'Documents in separate windows' #2068

Merged
merged 9 commits into from
Sep 6, 2024

Conversation

Minzihao
Copy link
Contributor

@Minzihao Minzihao commented Sep 5, 2024

What

尽可能地避免出现文档渲染不一致的问题,但是没有从根本上解决

Why

Issues 2009

"没有办法完全强制不允许使用tabbar,我只能做到当用户选择Documents in separate windows的时候,用户无法显示tabbar。然而Documents in separate windows这个情况,用户新建一个文档,在新的窗口那里又选择Multiple Document shared window,那么新的窗口又可以显示tabbar,然后在tabbar关闭新建的文档,又会出现luozhiya提出的这个问题。"

这个pr是昨天就写好了的,虽然没有从根本上解决luozhiya提出的这个问题,但是当用户选择Documents in separate windows的时候按道理不应该显示Tabbar。

所以这个pr优化的问题是:当用户选择Documents in separate windows的时候自动隐藏Tabbar(但不是禁用,因为正如上述,用户还能有途径显示tabbar)。

@da-liii @Oyyko @luozhiya

@@ -1979,6 +1979,8 @@
("system environment variables" "")
("tab bar" "标签页工具栏")
("tab" "")
("tab" "制表符")
("tab bar" "标签栏")
Copy link
Contributor

@da-liii da-liii Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个我上次翻译过了,上面(1980行)的标签页工具栏

Copy link
Contributor

@da-liii da-liii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Minzihao Minzihao merged commit 096949b into branch-1.2 Sep 6, 2024
@Minzihao Minzihao deleted the inconsistent-document-rendering branch September 6, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants