Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semrush move links and link params to client side and tests #21865

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

vraja-pro
Copy link
Contributor

@vraja-pro vraja-pro commented Nov 27, 2024

Context

Summary

This PR can be summarized in the following changelog entry:

  • Relocate related keyphrase suggestions links to client side a add tests to the modal content component.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Make sure Yoast premium is deactivate.
  • Edit a post with focus key phrase and click on "Get related keyphrase", log in to your SEMrush account.
  • Check the modal has Yoast Premium ad link has link params:

https://yoa.st/413?php_version=8.1&platform=wordpress&platform_version=6.7.1&software=free&software_version=24.0-RC2&days_active=20054&user_language=en_US

  • Change the focus keyphrase and reopen the modal several times until you reach the limit of semrush request, check the link has params as above.

For code review

  • Tests the screens shots ( according to the name of the test ):
    • The content of the results appear in the table.
    • The alerts message appears as expected.
    • The Premium upsell link and the semrush link appears as expected.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes Semrush table cleanup and tests

@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Nov 27, 2024
@vraja-pro vraja-pro added this to the feature/plugin-fixes milestone Nov 27, 2024
@coveralls
Copy link

coveralls commented Nov 27, 2024

Pull Request Test Coverage Report for Build 3f2615f0c7c87752cd9dd8a0594dd1f0ad6ddca8

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 54.417%

Files with Coverage Reduction New Missed Lines %
packages/js/src/containers/SEMrushRelatedKeyphrases.js 1 0.0%
Totals Coverage Status
Change from base Build b602854da9bd10c690131950c0472809c3328df6: 0.03%
Covered Lines: 29946
Relevant Lines: 55463

💛 - Coveralls

@pls78 pls78 force-pushed the feature/plugin-fixes branch from ce4d990 to 3997998 Compare December 4, 2024 13:48
@enricobattocchi enricobattocchi changed the base branch from feature/plugin-fixes to trunk December 6, 2024 11:09
@enricobattocchi enricobattocchi changed the base branch from trunk to feature/plugin-fixes December 6, 2024 11:09
@enricobattocchi enricobattocchi changed the base branch from feature/plugin-fixes to trunk December 6, 2024 11:13
@vraja-pro vraja-pro modified the milestones: feature/plugin-fixes, 24.2 Dec 6, 2024
@enricobattocchi enricobattocchi removed this from the 24.2 milestone Dec 6, 2024
@vraja-pro vraja-pro force-pushed the semrush-move-links-and-link-params-to-client-side branch 2 times, most recently from 6302a1b to 39c152f Compare December 6, 2024 11:35
@vraja-pro vraja-pro self-assigned this Dec 13, 2024
@vraja-pro vraja-pro force-pushed the semrush-move-links-and-link-params-to-client-side branch from 39c152f to 9809a34 Compare December 13, 2024 08:08
@vraja-pro vraja-pro changed the title Semrush move links and link params to client side Semrush move links and link params to client side and tests Dec 13, 2024
@vraja-pro vraja-pro assigned vraja-pro and unassigned vraja-pro Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Semrush table cleanup and tests
3 participants