Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multizone rack awareness #41

Merged
merged 6 commits into from
Aug 5, 2017
Merged

Multizone rack awareness #41

merged 6 commits into from
Aug 5, 2017

Conversation

@solsson solsson changed the base branch from master to kafka-011 July 19, 2017 05:08
@solsson
Copy link
Contributor Author

solsson commented Jul 19, 2017

I think it's time to introduce an init container (or "sidecar") that replaces the ever growing command: in the kafka StatefulSet yaml. Node label lookup won't be as easy as --override broker.id=${HOSTNAME##*-}.

@solsson
Copy link
Contributor Author

solsson commented Aug 2, 2017

Explains why node name but no other node attributes are available via downward API, and thus why we need API calls: kubernetes/kubernetes#25957

@solsson solsson force-pushed the multizone-rack-awareness branch from e919456 to 8ee2ef6 Compare August 2, 2017 10:56
@solsson
Copy link
Contributor Author

solsson commented Aug 3, 2017

I picked the zone lookup kubectl command from #56 but avoided the RBAC. The RBAC part needs more scrutiny so I'll add it as an addon branch.

@solsson
Copy link
Contributor Author

solsson commented Aug 3, 2017

Verified on GKE. Some error cases verified on minikube (which naturally lacks the label).

https://github.com/wurstmeister/kafka-docker#broker-rack has a strategy for AWS but I'm assuming because of https://kubernetes.io/docs/concepts/configuration/assign-pod-node/#interlude-built-in-node-labels that the label is set there too.

@solsson solsson force-pushed the multizone-rack-awareness branch from 16236cd to ff972b9 Compare August 5, 2017 05:04
@solsson
Copy link
Contributor Author

solsson commented Aug 5, 2017

Got RBAC policy from 13520a6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant