-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multizone rack awareness #41
Conversation
I think it's time to introduce an init container (or "sidecar") that replaces the ever growing |
07d4a88
to
c29d220
Compare
c29d220
to
b7f95d2
Compare
Explains why node name but no other node attributes are available via downward API, and thus why we need API calls: kubernetes/kubernetes#25957 |
e919456
to
8ee2ef6
Compare
I picked the zone lookup kubectl command from #56 but avoided the RBAC. The RBAC part needs more scrutiny so I'll add it as an addon branch. |
Verified on GKE. Some error cases verified on minikube (which naturally lacks the label). https://github.com/wurstmeister/kafka-docker#broker-rack has a strategy for AWS but I'm assuming because of https://kubernetes.io/docs/concepts/configuration/assign-pod-node/#interlude-built-in-node-labels that the label is set there too. |
16236cd
to
ff972b9
Compare
Got RBAC policy from 13520a6 |
Important when you have zones > 1 and kafka replicas > zones.