booth: Map simple $macc instances too
#4787
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
widlarizer
approved these changes
Dec 2, 2024
| EOF | ||
| synth -run :fine | ||
| # test compatibility with alumacc |
There was a problem hiding this comment.
I think that ideally at this point we would assert the presence of $macc to make sure we're testing what we want to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the reasons/motivation for this change?
As it stands
boothignores$macccells, which means one cannot sequenceboothafteralumacc. Make the change toboothto handle at least the basic$macccells which represent a simple product. The more advanced case in which$maccis a combined multiply-accumulate operation is left for later to be dealt with