Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pilot 3 mapping: Prices #16

Open
Polymathronic opened this issue Apr 7, 2016 · 13 comments
Open

Pilot 3 mapping: Prices #16

Polymathronic opened this issue Apr 7, 2016 · 13 comments
Assignees
Labels

Comments

@Polymathronic
Copy link
Contributor

The pilot 3 mapping spreadsheet has contract_initial_value_cost_eur mapped to both pc:actualPrice and pc:estimatedPrice. Is this just a mistake in the spreadsheet or also in your ETL pipeline?

@mogaio
Copy link

mogaio commented Apr 7, 2016

the spreadsheet is not updated ... we will update it once we finalize the pipeline

@vafopoulos
Copy link
Contributor

If you do not updated, we cannot make proposals or review

@mogaio
Copy link

mogaio commented Apr 11, 2016

The spreadsheet is now updated and shared with you, you can access it from this url:
https://docs.google.com/spreadsheets/u/1/d/1_Cw8HtrBH8Jlhw_6MNdTrV4SeaT-ixyWhaiSc4zdMSg/edit?usp=drive_web

@Polymathronic
Copy link
Contributor Author

Shouldn't the 'Resource' show the resources an object property points to? An RDF snippet demonstrating the usage of the property would also make sense. It's currently showing the URLs of the properties (and not even all of them), which is redundant, as those can be inferred based on the prefixes.

@Polymathronic
Copy link
Contributor Author

Also, the description of contract_contract_value_cost_eur seems to be suggesting that it should be mapped to pc:agreedPrice, rather than pc:actualPrice:

After a tender is awarded a Contract, a price is agreed between the awarded supplier and the contracting authority. This property assigns that price to the Contract.

pc:actualPrice is the "actual price after contract realization".

@giorgosvaf
Copy link
Contributor

I think you should check your mapping again.

Please check the following comments,

  1. You don't need to map gr:hasCurrencyValue to contract_contract_value_cost_eur or to contract_initial_value_cost because gr:hasCurrencyValue is used for the amount in general.
    For instance you have to map contract_contract_value_cost_eur to pc:agreedPrice or whichever is the correct mapping just like you did in pc:documentsPrice case.
  2. I don't see anywhere in the document the property pc:agreedPrice
  3. I see that you use both pc:agreedPrice and pc:estimatedPrice for a specific instance of pc:Contract which conceptually is wrong, because that way you can not specify that you are describing different kinds of contacts, if you consider that you start from the same resource in both cases.

Query,

select distinct * 
from <http://yourdatastories.eu/pilot3> 
where {
<http://linkedeconomy.org/resource/Contract/800377> ?p ?o
} 

@Polymathronic
Copy link
Contributor Author

Do these bits of information (estimated and agreed price) refer to, essentially, different concepts? Seeing the original data source could help, I guess.

@giorgosvaf
Copy link
Contributor

Depending on your data please explain why you use estimated and agreed price based on examples(correct mapping and short comment why you use it).

Then also explain why you use estimated and agreed price on the same contract resource and why you use different approach from pilot 1 where each contract has one of the above prices in order to specify the different phase of individual contracts.

@LUKPOR
Copy link

LUKPOR commented Apr 12, 2016

We believe (based on our data) that contract_initial_value_cost_eur should be mapped to pc:estimatedPrice and contract_contract_value_cost_eur should be mapped to pc:agreedPrice. We believe pc:actualPrice should be omitted. It is reasonable to say that whenever there is a contract, first the estimated price is given (initial value) then it is negotiated and approved - agreed price. The actual price which is the actual cost (or the actual claim made against the contractual, agreed price) is most probably not considered in that dataset, especially that many of the projects are ongoing projects (therefore, it is impossible to have the exact amount claimed). Therefore, it makes perfect sense to keep both estimated and agreed price for the same contract and the actual price can be left out. In fact, the actual price goes beyond the contract - more explanation in the email.

@giorgosvaf
Copy link
Contributor

  1. As far i see the mapping seems to be right.
  2. About contract resource and prices issue, this approach does make sense but you have to consider the following,
    If you have for the same resource both estimated and agreed price, you will not be able to know the phase that the contract belongs to(contract or tender phase).
    For example, tender phase (estimated price) is not supposed to have any seller(if added) but contract phase(agreed price) could have, so if you have the same URI and link the resource to the seller, you will have a URI which will point to different entities actually(tender & contract phase) and you will not be able to know in which phase the seller was linked to.

A Possible solution on this would be the following,
estimated Price:
http://linkedeconomy.org/resource/Contract/Tender/1302039 pc:estimatedPrice ...
agreed Price:
http://linkedeconomy.org/resource/Contract/Contract/1302039 pc:agreedPrice ...

If you follow what you have now, it's not impossible to have internal model issues in the future.
We will expect your comments and your implementation in order to move forward.

Hope that helps.

@Polymathronic
Copy link
Contributor Author

Since you already have the concept of a tender, that would essentially mean you would just have to attach the estimated prices to tenders, instead of contracts. Right George?

@giorgosvaf
Copy link
Contributor

I meant, the tender phase of a contract, not the pc:Tender class.

pc:agreedPrice & pc:estimatedPrice must have pc:Contract as domain class.

@Polymathronic
Copy link
Contributor Author

OK. @mogaio please follow the pilot 1 approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants