-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pilot 3 mapping: Prices #16
Comments
the spreadsheet is not updated ... we will update it once we finalize the pipeline |
If you do not updated, we cannot make proposals or review |
The spreadsheet is now updated and shared with you, you can access it from this url: |
Shouldn't the 'Resource' show the resources an object property points to? An RDF snippet demonstrating the usage of the property would also make sense. It's currently showing the URLs of the properties (and not even all of them), which is redundant, as those can be inferred based on the prefixes. |
Also, the description of
|
I think you should check your mapping again. Please check the following comments,
Query,
|
Do these bits of information (estimated and agreed price) refer to, essentially, different concepts? Seeing the original data source could help, I guess. |
Depending on your data please explain why you use estimated and agreed price based on examples(correct mapping and short comment why you use it). Then also explain why you use estimated and agreed price on the same contract resource and why you use different approach from pilot 1 where each contract has one of the above prices in order to specify the different phase of individual contracts. |
We believe (based on our data) that contract_initial_value_cost_eur should be mapped to pc:estimatedPrice and contract_contract_value_cost_eur should be mapped to pc:agreedPrice. We believe pc:actualPrice should be omitted. It is reasonable to say that whenever there is a contract, first the estimated price is given (initial value) then it is negotiated and approved - agreed price. The actual price which is the actual cost (or the actual claim made against the contractual, agreed price) is most probably not considered in that dataset, especially that many of the projects are ongoing projects (therefore, it is impossible to have the exact amount claimed). Therefore, it makes perfect sense to keep both estimated and agreed price for the same contract and the actual price can be left out. In fact, the actual price goes beyond the contract - more explanation in the email. |
A Possible solution on this would be the following, If you follow what you have now, it's not impossible to have internal model issues in the future. Hope that helps. |
Since you already have the concept of a tender, that would essentially mean you would just have to attach the estimated prices to tenders, instead of contracts. Right George? |
I meant, the tender phase of a contract, not the pc:Tender class. pc:agreedPrice & pc:estimatedPrice must have pc:Contract as domain class. |
OK. @mogaio please follow the pilot 1 approach. |
The pilot 3 mapping spreadsheet has
contract_initial_value_cost_eur
mapped to bothpc:actualPrice
andpc:estimatedPrice
. Is this just a mistake in the spreadsheet or also in your ETL pipeline?The text was updated successfully, but these errors were encountered: