Skip to content

Commit

Permalink
prepare release script
Browse files Browse the repository at this point in the history 
Signed-off-by: Nikolaj Bjorner <[email protected]>
  • Loading branch information
@NikolajBjorner
NikolajBjorner committed Nov 14, 2023
1 parent ad2107f commit 7ed27a1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/release.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -582,7 +582,7 @@ stages:

# Enable on release:
- job: PyPIPublish
condition: eq(1,1)
condition: eq(1,0)
displayName: "Publish to PyPI"
pool:
vmImage: "ubuntu-latest"
Expand Down

6 comments on commit 7ed27a1

@nunoplopes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey, please don't do a release right now!!🥺
Floats are very broken; we can't have a release before the fix lands.

@wintersteiger
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will take some time to get an actual fix, but I'll revert the unsound change to the theory solver. Apart from that, conversion of floats to ints is potentially broken too, but I don't have a quick fix for that.

@NikolajBjorner
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definition of what it means not to have a life: read commit messages and make inferences from that 1 changes to 0 in a random file.

@nunoplopes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definition of what it means not to have a life: read commit messages and make inferences from that 1 changes to 0 in a random file.

Somebody has gotta do it so you don't have to.

@NikolajBjorner
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yo, low-life, lola-live, etc. Can I package a release with the latest updates to FP?

@nunoplopes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me, sir! The Alive2 run from yesterday was good.
Thank you 🚀

Please sign in to comment.