Added decide-callback to user-propagator #5978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| scoped_cb _cb(p, cb); | ||
| expr val(p->ctx(), _val); | ||
| p->m_decide_eh(val, bit, is_pos); | ||
| _val = val; |
There was a problem hiding this comment.
the expression val is declared locally. The reference count is invalid when thedecide_eh goes out of scope. The expression _val is passed to the solver.
If the reference count is not owned by the solver, this call will crash.
It can be expected the reference count isn't fully owned locally because the expression should be already registered. So the issue shouldn't manifest. OTOH, it is fragile and makes assumptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now just for the legacy solver