remove operation with doubles #6623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lev Nachmanson <[email protected]>
Signed-off-by: Lev Nachmanson <[email protected]>
Signed-off-by: Lev Nachmanson <[email protected]>
Signed-off-by: Lev Nachmanson <[email protected]>
Signed-off-by: Lev Nachmanson <[email protected]>
Signed-off-by: Lev Nachmanson <[email protected]>
Signed-off-by: Lev Nachmanson <[email protected]>
Signed-off-by: Lev Nachmanson <[email protected]>
This reverts commit 547254a.
Signed-off-by: Lev Nachmanson <[email protected]>
|
Still there is some dead code, but at this moment a review might be helpful. |
| m_out << s << " "; | ||
| } | ||
| m_out << std::endl; | ||
| return; |
There was a problem hiding this comment.
add comment in code to mark for deletion
src/math/lp/lar_solver.cpp
Outdated
| @@ -285,7 +282,7 @@ namespace lp { | |||
| clean_popped_elements(m, m_rows_with_changed_bounds); | |||
| clean_inf_set_of_r_solver_after_pop(); | |||
| lp_assert(m_settings.simplex_strategy() == simplex_strategy_enum::undecided || | |||
| (!use_tableau()) || m_mpq_lar_core_solver.m_r_solver.reduced_costs_are_correct_tableau()); | |||
| ( m_mpq_lar_core_solver.m_r_solver.reduced_costs_are_correct_tableau())); | |||
src/math/lp/lar_solver.cpp
Outdated
| m_mpq_lar_core_solver.m_r_solver.solve_Bd(j, m_column_buffer); | ||
| for (unsigned i : m_column_buffer.m_index) | ||
| insert_row_with_changed_bounds(i); | ||
| lp_assert(false); |
There was a problem hiding this comment.
Use UNREACHABLE() instead of lp_assert(false)
add comment to mark for deletion
src/math/lp/lar_solver.cpp
Outdated
| @@ -696,7 +676,7 @@ namespace lp { | |||
| } | |||
|
|
|||
| void lar_solver::change_basic_columns_dependend_on_a_given_nb_column(unsigned j, const numeric_pair<mpq>& delta) { | |||
| if (use_tableau()) { | |||
| { | |||
There was a problem hiding this comment.
how many { are needed?
src/math/lp/lp_primal_core_solver.h
Outdated
| @@ -1000,7 +914,7 @@ class lp_primal_core_solver:public lp_core_solver_base<T, X> { | |||
| m_lower_bounds_dummy.resize(A.column_count(), zero_of_type<T>()); | |||
| m_enter_price_eps = numeric_traits<T>::precise() ? numeric_traits<T>::zero() : T(1e-5); | |||
| #ifdef Z3DEBUG | |||
| // check_correctness(); | |||
| lp_assert(false); | |||
| if ((!numeric_traits<T>::precise()) && this->A_mult_x_is_off()) { | ||
| this->set_status(lp_status::FLOATING_POINT_ERROR); | ||
| return 0; | ||
| } | ||
| do { |
There was a problem hiding this comment.
If you delete !numeric_traits::precise() as option, then other occurrences can be removed
| break; | ||
| } | ||
| init_reduced_costs(); | ||
| lp_assert(false); |
Signed-off-by: Lev Nachmanson <[email protected]>
Signed-off-by: Lev Nachmanson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.