Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory and concurrency issues in OCaml API #6992

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Fix memory and concurrency issues in OCaml API #6992

merged 2 commits into from
Nov 17, 2023

Conversation

wintersteiger
Copy link
Contributor

Fixes multiple issues with the OCaml API:

  • Global hash table for constructor objects meant that all contexts that use datatypes were never garbage collected
    • Adds Z3_constructor_num_fields to remove the need for the hash table
  • Flush API solver objects more eagerly
  • Fixes a latent memory leak in Z3.Goal.simplify
  • Makes the object count of OCaml context trackers _Atomic where available
  • Fixes a latent race on api::context::m_allocated_objects

@wintersteiger wintersteiger marked this pull request as ready for review November 14, 2023 22:11
NikolajBjorner added a commit that referenced this pull request Nov 15, 2023
@NikolajBjorner
add comment regarding usage model for flush_objects() to relate with pr
f1a39b8 
#6992

Signed-off-by: Nikolaj Bjorner <[email protected]>
@NikolajBjorner NikolajBjorner merged commit 36382cc into Z3Prover:master Nov 17, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikolajBjorner NikolajBjorner NikolajBjorner left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wintersteiger @NikolajBjorner