Returns isvalid: false instead of conversion error

ZcashFoundation · Feb 2, 2023 · a45bff8 · a45bff8
1 parent 332b55c
commit a45bff8
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/zebra-rpc/src/methods/get_block_template_rpcs.rs b/zebra-rpc/src/methods/get_block_template_rpcs.rs
@@ -792,13 +792,14 @@ where
                     return Ok(validate_address::Response::invalid());
                 };
 
-            let address = address
-                .convert::<primitives::Address>()
-                .map_err(|err| Error {
-                    code: ErrorCode::ServerError(0),
-                    message: format!("conversion error: {err}"),
-                    data: None,
-                })?;
+            let address = match address
+                .convert::<primitives::Address>() {
+                    Ok(address) => address,
+                    Err(err) => {
+                        tracing::debug!(?err, "conversion error");
+                        return Ok(validate_address::Response::invalid());
+                    }
+                };
 
             // we want to match zcashd's behaviour
             if !address.is_transparent() {