Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate lightwalletd RPCs in Docker image when RPC port is set #7166

Closed
teor2345 opened this issue Jul 6, 2023 · 1 comment · Fixed by #7177
Closed

Activate lightwalletd RPCs in Docker image when RPC port is set #7166

teor2345 opened this issue Jul 6, 2023 · 1 comment · Fixed by #7177
Assignees
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-rpc Area: Remote Procedure Call interfaces C-bug Category: This is a bug I-usability Zebra is hard to understand or use

Comments

@teor2345
Copy link
Contributor

teor2345 commented Jul 6, 2023

Motivation

The runtime-entrypoint.sh uses the RPC_PORT env var when the user
specifies the getblocktemplate-rpc feature

Some users might want to use the Docker image with lightwalletd, but without configuring getblocktemplate-rpcs. So let's work out how to do that!

Previously, the Dockerfile only activated the RPC port when it was set, but I agree that doesn't make sense with getblocktemplate-rpcs:
8c90f65#diff-5b838857fc3410c2438196effdbdcffae6548bdba431a4a938e76a0be62d008eL49

So we might want logic like:

  • If getblocktemplate-rpcs is activated, activate the default RPC port if it is unset
  • If there aren't any active RPC features, activate the RPC port only if it is set
  • Otherwise, don't activate the RPC port

This covers the 3 different use cases of mining, light wallet, and no RPCs.

Originally posted by @teor2345 in #7162 (review)

@mpguerra mpguerra added this to Zebra Jul 6, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Zebra Jul 6, 2023
@teor2345 teor2345 added C-bug Category: This is a bug A-devops Area: Pipelines, CI/CD and Dockerfiles P-Medium ⚡ I-usability Zebra is hard to understand or use A-rpc Area: Remote Procedure Call interfaces labels Jul 7, 2023
@teor2345
Copy link
Contributor Author

teor2345 commented Jul 7, 2023

We could also have another env var that activates the RPC port the same way that the getblocktemplate feature does. (Just with the default ports.)

@teor2345 teor2345 added the S-needs-triage Status: A bug report needs triage label Jul 7, 2023
@upbqdn upbqdn self-assigned this Jul 8, 2023
@upbqdn upbqdn removed the S-needs-triage Status: A bug report needs triage label Jul 8, 2023
@mergify mergify bot closed this as completed in #7177 Jul 10, 2023
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Zebra Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-rpc Area: Remote Procedure Call interfaces C-bug Category: This is a bug I-usability Zebra is hard to understand or use
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants