fix(Docker): Set default RPC_PORT
#7162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upbqdn
added
C-bug
arya2
dismissed
their stale review
Let's make sure it works with --target runtime too.
The `runtime-entrypoint.sh` uses the `RPC_PORT` env var when the user specifies the `getblocktemplate-rpc` feature, but this env var is unset unless the user sets it. This commit sets the default values for `RPC_PORT` depending on `NETWORK`.
upbqdn
force-pushed
the
fix-dockerfile-entrypoint
branch
from
f50331b to
a81c309
Compare
teor2345
approved these changes
Jul 6, 2023
There was a problem hiding this comment.
The
runtime-entrypoint.shuses theRPC_PORTenv var when the user
specifies thegetblocktemplate-rpcfeature
Some users might want to use the Docker image with lightwalletd, but without configuring getblocktemplate-rpcs. So let's work out how to do that in another ticket.
Previously, the Dockerfile only activated the RPC port when it was set, but I agree that doesn't make sense with getblocktemplate-rpcs:
8c90f65#diff-5b838857fc3410c2438196effdbdcffae6548bdba431a4a938e76a0be62d008eL49
So we might want logic like:
- If
getblocktemplate-rpcsis activated, activate the default RPC port if it is unset - If there aren't any active RPC features, activate the RPC port only if it is set
- Otherwise, don't activate the RPC port
This covers the 3 different use cases of mining, light wallet, and no RPCs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I noticed we were using an unset
RPC_PORTin the runtime entry point.Solution
The
runtime-entrypoint.shuses theRPC_PORTenv var when the userspecifies the
getblocktemplate-rpcfeature, but this env var is unsetunless the user sets it. This commit sets the default values for
RPC_PORTdepending onNETWORK.Reviewer Checklist