Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve scans_for_new_key test #8236

Closed
Tracked by #7728
arya2 opened this issue Feb 5, 2024 · 2 comments
Closed
Tracked by #7728

Improve scans_for_new_key test #8236

arya2 opened this issue Feb 5, 2024 · 2 comments
Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions C-testing Category: These are tests P-Medium ⚡ S-blocked Status: Blocked on other tasks

Comments

@arya2
Copy link
Contributor

arya2 commented Feb 5, 2024

Motivation

This test doesn't currently check specific transactions in the results at specific heights. It also doesn't test if Zebra starts scanning for blocks from the start height when it's restarted after a key is registered but before the scan_range() task is finished.

This issue depends on correctly handling ScanTask restarts before a scan_range() task for a newly registered key is finished. See #8238.

Possible Design

  • Use ScanService requests to register key and get results instead of ScanTask
  • Check for known transaction ids and heights in the test
  • Check that it returns scans all of the blocks in the required range when ScanTask restarts before the scan_range() task is finished
@arya2 arya2 added A-devops Area: Pipelines, CI/CD and Dockerfiles C-testing Category: These are tests A-blockchain-scanner Area: Blockchain scanner of shielded transactions P-Low ❄️ labels Feb 5, 2024
@github-project-automation github-project-automation bot moved this to New in Zebra Feb 5, 2024
@arya2 arya2 added S-blocked Status: Blocked on other tasks and removed S-blocked Status: Blocked on other tasks labels Feb 6, 2024
@mpguerra mpguerra moved this from New to Product Backlog in Zebra Feb 7, 2024
@mpguerra mpguerra moved this from Product Backlog to Sprint Backlog in Zebra Feb 13, 2024
@arya2 arya2 self-assigned this Feb 15, 2024
@arya2
Copy link
Contributor Author

arya2 commented Feb 15, 2024

Split out adding the test to CI to #8274. The rest of this issue is blocked on handling restarts correctly (See #8238).

@arya2 arya2 removed their assignment Feb 15, 2024
@arya2 arya2 changed the title Improve scans_for_new_key test and add it to CI Improve scans_for_new_key test Feb 15, 2024
@arya2 arya2 added the S-blocked Status: Blocked on other tasks label Feb 15, 2024
@arya2 arya2 removed the A-devops Area: Pipelines, CI/CD and Dockerfiles label Feb 19, 2024
@mpguerra mpguerra moved this from Sprint Backlog to Product Backlog in Zebra Feb 29, 2024
@mpguerra
Copy link
Contributor

We won't be doing any more work on the scanner

@mpguerra mpguerra closed this as not planned Won't fix, can't repro, duplicate, stale Oct 18, 2024
@github-project-automation github-project-automation bot moved this from Product Backlog to Done in Zebra Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions C-testing Category: These are tests P-Medium ⚡ S-blocked Status: Blocked on other tasks
Projects
Status: Done
Development

No branches or pull requests

2 participants