Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add(scan): Run scans_for_new_key and scan_subscribe_results tests in CI #8275

Closed
wants to merge 7 commits into from

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented Feb 15, 2024

Motivation

We want to run these tests in CI.

Closes #8274.
Closes #8259.

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?
For significant changes:
  • Is there a summary in the CHANGELOG?
  • Can these changes be split into multiple PRs?

If a checkbox isn't relevant to the PR, mark it as done.

Solution

  • Add the tests to entrypoint.sh
  • Add the tests to GCP integration test workflow

Review

Anyone can review.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

Follow Up Work

@arya2 arya2 added A-devops Area: Pipelines, CI/CD and Dockerfiles C-testing Category: These are tests A-blockchain-scanner Area: Blockchain scanner of shielded transactions P-Medium ⚡ labels Feb 15, 2024
@arya2 arya2 self-assigned this Feb 15, 2024
@arya2 arya2 requested a review from a team as a code owner February 15, 2024 18:21
@arya2 arya2 requested review from upbqdn and removed request for a team February 15, 2024 18:21
@github-actions github-actions bot added C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Feb 15, 2024
@arya2 arya2 changed the title add(scan): Run scans_for_new_key and scan_subscribe_results tests in CI add(scan): Run scans_for_new_key and scan_subscribe_results tests in CI Feb 15, 2024
@arya2 arya2 removed the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Feb 15, 2024
@arya2 arya2 marked this pull request as draft February 15, 2024 20:28
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Feb 15, 2024
@arya2 arya2 force-pushed the add-scan-tests-to-ci branch from 09bfe52 to 0c2c0c8 Compare February 15, 2024 20:34
@arya2
Copy link
Contributor Author

arya2 commented Feb 15, 2024

The tests pass, but it's exiting with an exit code of 1 somehow: https://github.com/ZcashFoundation/zebra/actions/runs/7923158455/job/21632648787?pr=8275#step:15:261

It seems to emit an exit code of 0 locally.

There's also an unrelated port conflict in the latest run of 'Test All'

@upbqdn upbqdn removed the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Feb 19, 2024
@arya2
Copy link
Contributor Author

arya2 commented Feb 20, 2024

I'll unify these tests for #8286 first and re-open this PR to add the new test to CI.

@arya2 arya2 closed this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions A-devops Area: Pipelines, CI/CD and Dockerfiles C-testing Category: These are tests P-Medium ⚡
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add scans_for_new_key test to CI Add scan_subscribe_results test to CI
2 participants