Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): Reduce false positives for the C-trivial label #5309

Merged
merged 2 commits into from
Oct 3, 2022
Merged

fix(ci): Reduce false positives for the C-trivial label #5309

merged 2 commits into from
Oct 3, 2022

Conversation

upbqdn
Copy link
Member

@upbqdn upbqdn commented Oct 2, 2022 •
edited
Loading

Motivation

release-drafter erroneously labeled PR #5164 as C-trivial. It did so because the PR edited the file zcash-rpc-diff in zebra-utils.

Solution

This PR deletes zebra-utils from the confing file for release-drafter.

Review

We can't test this PR until we merge it to main.

Reviewer Checklist

  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?

@upbqdn upbqdn requested a review from a team as a code owner October 2, 2022 23:45
@upbqdn upbqdn requested review from teor2345 and removed request for a team October 2, 2022 23:45
@github-actions github-actions bot added C-bug Category: This is a bug C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Oct 2, 2022
@upbqdn upbqdn added A-devops Area: Pipelines, CI/CD and Dockerfiles and removed C-bug Category: This is a bug labels Oct 2, 2022
@upbqdn upbqdn self-assigned this Oct 2, 2022
@upbqdn upbqdn added the C-bug Category: This is a bug label Oct 2, 2022
mergify bot added a commit that referenced this pull request Oct 3, 2022
@mergify
Merge of #5309
3add703
@mergify mergify bot mentioned this pull request Oct 3, 2022
Closed
@mergify mergify bot merged commit 1f4a1b4 into main Oct 3, 2022
@mergify mergify bot deleted the fix-release-drafter-config branch October 3, 2022 01:45
@teor2345 teor2345 mentioned this pull request Oct 11, 2022
Merged
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teor2345 teor2345 teor2345 approved these changes

Assignees

@upbqdn upbqdn

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-bug Category: This is a bug C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@upbqdn @teor2345