Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(lint): do not fail linter on push events #5331

Merged
merged 1 commit into from
Oct 4, 2022
Merged

ci(lint): do not fail linter on push events #5331

merged 1 commit into from
Oct 4, 2022

Conversation

gustavovalverde
Copy link
Member

Previous behavior

The following error was causing an exit 1 in GitHub Actions when a pushing to the main branch

Error: Similar commit hashes detected: previous sha is equivalent to the
current sha

Expected behavior

Allow the linter to run sucesfully even if the previous SHA has no files changed

Solution:

Add fetch-depth: 2 to retrieve the preceding commit

Review

Anyone can review this

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
  • How do you know it works? Does it have tests?

@gustavovalverde
ci(lint): do not fail linter on push events
3712010 
Previous behavior:
The following error was causing an exit 1 in GitHub Actions when a pushing
to the `main` branch

```
Error: Similar commit hashes detected: previous sha is equivalent to the
current sha
```

Expeceted behavior:
Allow the linter to run succesfully even if the previous SHA has no files
changed

Solution:
Add `fetch-depth: 2` to retrieve the preceding commit
@gustavovalverde gustavovalverde added C-bug Category: This is a bug A-devops Area: Pipelines, CI/CD and Dockerfiles P-Critical 🚑 I-integration-fail Continuous integration fails, including build and test failures labels Oct 4, 2022
@gustavovalverde gustavovalverde self-assigned this Oct 4, 2022
@gustavovalverde gustavovalverde requested a review from a team as a code owner October 4, 2022 18:44
@gustavovalverde gustavovalverde requested review from dconnolly and removed request for a team October 4, 2022 18:44
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Oct 4, 2022
teor2345
teor2345 approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mergify mergify bot merged commit a418985 into main Oct 4, 2022
@mergify mergify bot deleted the fix-linting-issue branch October 4, 2022 19:00
@teor2345 teor2345 mentioned this pull request Oct 11, 2022
Merged
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teor2345 teor2345 teor2345 approved these changes

@dconnolly dconnolly Awaiting requested review from dconnolly dconnolly is a code owner automatically assigned from ZcashFoundation/devops-reviewers

Assignees

@gustavovalverde gustavovalverde

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-bug Category: This is a bug C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG I-integration-fail Continuous integration fails, including build and test failures
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gustavovalverde @teor2345