Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sync): Make timeouts shorter to reduce full sync times #5397

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

teor2345
Copy link
Contributor

Motivation

The full sync is timing out, so we want to reduce the amount of time we wait for stuck blocks.

Solution

Reduce the default block timeout to 8 minutes, and the final checkpoint timeout to 2 minutes.

Review

@arya2 is also working on fixing this.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
  • How do you know it works? Does it have tests?

Follow Up Work

Increase the Rust test or workflow job timeouts, if needed.

@teor2345 teor2345 added C-bug Category: This is a bug P-Critical 🚑 I-slow Problems with performance or responsiveness I-integration-fail Continuous integration fails, including build and test failures labels Oct 12, 2022
@teor2345 teor2345 self-assigned this Oct 12, 2022
@teor2345 teor2345 requested a review from a team as a code owner October 12, 2022 21:02
@teor2345 teor2345 requested review from oxarbitrage and removed request for a team October 12, 2022 21:02
@teor2345
Copy link
Contributor Author

macOS tests failed due to a network error and bug #4649:

assertion failed: output.stdout_line_contains("activating mempool").is_err()

https://github.com/ZcashFoundation/zebra/actions/runs/3237875279/jobs/5305448541#step:15:520

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #5397 (32a25a1) into main (8e5425f) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5397   +/-   ##
=======================================
  Coverage   79.10%   79.11%           
=======================================
  Files         308      308           
  Lines       39752    39752           
=======================================
+ Hits        31447    31449    +2     
+ Misses       8305     8303    -2     

mergify bot added a commit that referenced this pull request Oct 14, 2022
@mergify mergify bot merged commit fd517ee into main Oct 14, 2022
@mergify mergify bot deleted the shorter-full-sync-timeouts branch October 14, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug I-integration-fail Continuous integration fails, including build and test failures I-slow Problems with performance or responsiveness
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants