Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Remove arrayvec and itoa from skip-tree #5410

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

upbqdn
Copy link
Member

@upbqdn upbqdn commented Oct 14, 2022

Motivation

We recently updated inferno, which depends on num_format, which depends on arrayvec and itoa, and running

cargo deny --all-features check bans

started producing the following warnings:

   ┌─ .../zebra/deny.toml:89:5
   │
89 │     { name = "arrayvec", version = "=0.4.12" },
   │     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no crate matched these criteria

warning[B010]: skip tree root was not found in the dependency graph
   ┌─ .../zebra/deny.toml:90:5
   │
90 │     { name = "itoa", version = "=0.4.8" },
   │     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no crate matched these criteria

bans ok

Solution

The warning means we don't need to list the arrayvec and itoa dependencies in the skip-tree section, so this PR removes them.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
  • How do you know it works? Does it have tests?

We recently updated `inferno`, and running
```bash
cargo deny --all-features check bans
```
started producing the following warnings:
```
   ┌─ .../zebra/deny.toml:89:5
   │
89 │     { name = "arrayvec", version = "=0.4.12" },
   │     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no crate matched these criteria

warning[B010]: skip tree root was not found in the dependency graph
   ┌─ .../zebra/deny.toml:90:5
   │
90 │     { name = "itoa", version = "=0.4.8" },
   │     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no crate matched these criteria

bans ok
```

The warning means we don't need to list the `arrayvec` and `itoa`
dependencies in the `skip-tree` section, so this commit removes them.
@upbqdn upbqdn requested a review from a team as a code owner October 14, 2022 16:07
@upbqdn upbqdn requested review from teor2345 and removed request for a team October 14, 2022 16:07
@github-actions github-actions bot added C-removed C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Oct 14, 2022
@upbqdn upbqdn added A-dependencies Area: Dependency file updates and removed C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG C-removed labels Oct 14, 2022
@upbqdn upbqdn self-assigned this Oct 14, 2022
@upbqdn upbqdn added C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Low ❄️ labels Oct 14, 2022
Copy link
Member

@gustavovalverde gustavovalverde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mergify bot added a commit that referenced this pull request Oct 18, 2022
@mergify mergify bot merged commit 1f4bc0d into main Oct 18, 2022
@mergify mergify bot deleted the remove-deps-from-deny-toml branch October 18, 2022 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Area: Dependency file updates C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants