Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Allow extra lookahead blocks in the verifier, state, and block commit task queues #5465

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Oct 24, 2022

Motivation

Full syncs are timing out on the main branch, with a lot of "synced block height too far ahead of the tip: dropped downloaded block" errors:
https://github.com/ZcashFoundation/zebra/actions/runs/3300574887/jobs/5458683486

Close #5420.

Solution

  • Allow extra capacity in the verifier queue, state queue, or block commit task channel

This will increase Zebra's memory usage, users can reduce memory usage by reducing the configured lookahead limit.

Review

We can only test this change by merging it to main.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
  • How do you know it works? Does it have tests?

@teor2345 teor2345 added C-bug Category: This is a bug A-rust Area: Updates to Rust code P-High 🔥 I-integration-fail Continuous integration fails, including build and test failures C-testing Category: These are tests A-state Area: State / database changes labels Oct 24, 2022
@teor2345 teor2345 self-assigned this Oct 24, 2022
@teor2345 teor2345 requested a review from a team as a code owner October 24, 2022 04:24
@teor2345 teor2345 requested review from oxarbitrage and removed request for a team October 24, 2022 04:24
@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Merging #5465 (dde1f24) into main (a2dba8c) will decrease coverage by 0.07%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5465      +/-   ##
==========================================
- Coverage   79.12%   79.04%   -0.08%     
==========================================
  Files         308      308              
  Lines       39324    39324              
==========================================
- Hits        31115    31084      -31     
- Misses       8209     8240      +31     

Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks.

@mergify mergify bot merged commit 737fbac into main Oct 24, 2022
@mergify mergify bot deleted the lookahead-fix branch October 24, 2022 14:55
teor2345 added a commit that referenced this pull request Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rust Area: Updates to Rust code A-state Area: State / database changes C-bug Category: This is a bug C-testing Category: These are tests I-integration-fail Continuous integration fails, including build and test failures
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix frequent "synced block height too far ahead of the tip: dropped downloaded block" errors
2 participants